fix(replay): Default ignore file inputs for dead clicks #14227
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
reviewed
Nov 11, 2024
| @@ -32,6 +32,8 @@ const MEDIA_SELECTORS = | |||
|
|
|||
| const DEFAULT_NETWORK_HEADERS = ['content-length', 'content-type', 'accept']; | |||
|
|
|||
| const DEFAULT_SLOW_CLICK_IGNORE_SELECTORS = ['input[type="file"]']; | |||
There was a problem hiding this comment.
Hmm wait, do we not already do that? in handleClick.ts we have this code:
// If <input> tag, we only want to consider input[type='submit'] & input[type='button']
if (node.tagName === 'INPUT' && !['submit', 'button'].includes(node.getAttribute('type') || '')) {
return true;
}There was a problem hiding this comment.
yeah you are right, the test also passes without the change 🤔
size-limit report 📦
|
|
Ah my fault @chargome -- is it worth keeping the test? |
billyvg
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a default selector for ignoring dead clicks on file inputs.
ref #80275