Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(opentelemetry): Bucket spans for cleanup #14154

Merged
merged 9 commits into from
Nov 27, 2024
Merged

perf(opentelemetry): Bucket spans for cleanup #14154

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
fcc75b6
perf(otel): Only cleanup old spans every interval once
fmorett Oct 31, 2024
70cc5dc
Avoid iterating through all open spans
lforst Nov 12, 2024
01f8d68
Actually write to the buckets
lforst Nov 12, 2024
c807a30
Fix tests
lforst Nov 12, 2024
ec96525
Merge branch 'develop' into develop
lforst Nov 13, 2024
ced2588
Remove leftover
lforst Nov 13, 2024
877e8f5
Add comment explaining
lforst Nov 14, 2024
65c18f0
lint
lforst Nov 14, 2024
8832fbf
Merge branch 'develop' into develop
lforst Nov 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Actually write to the buckets
  • Loading branch information
@lforst
lforst committed Nov 12, 2024
commit 01f8d688992ac5089238299b17033b62d30c0e9c
4 changes: 2 additions & 2 deletions packages/opentelemetry/src/spanExporter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ export class SentrySpanExporter {
}) {
this._finishedSpanBucketSize = options?.timeout || DEFAULT_TIMEOUT;
this._finishedSpanBuckets = new Array(this._finishedSpanBucketSize).fill(undefined);
this._lastCleanupTimestampInS = 0;
this._lastCleanupTimestampInS = Math.floor(Date.now() / 1000);
this._spansToBucketEntry = new WeakMap();
}

Expand All @@ -79,7 +79,7 @@ export class SentrySpanExporter {
timestampInS: currentTimestampInS,
spans: new Set(),
};

this._finishedSpanBuckets[currentBucketIndex] = currentBucket;
currentBucket.spans.add(span);
this._spansToBucketEntry.set(span, currentBucket);

Expand Down
Loading