Skip to content

fix(astro): waitUntil flush at end of request #14062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 31, 2024
Merged

Conversation

s1gr1d
Copy link
Member

@s1gr1d s1gr1d commented Oct 23, 2024

fixes #14054

@s1gr1d s1gr1d requested a review from Lms24 October 23, 2024 14:22
@s1gr1d s1gr1d force-pushed the sig/astro-waitUntil branch from c2a12dd to d8d1770 Compare October 24, 2024 09:09
@s1gr1d s1gr1d changed the base branch from sig/flush-util to develop October 24, 2024 09:15
@s1gr1d s1gr1d force-pushed the sig/astro-waitUntil branch from 5b9fc05 to 9526eeb Compare October 24, 2024 09:17
Copy link
Contributor

github-actions bot commented Oct 24, 2024

size-limit report 📦

⚠️ Warning: Base artifact is not the latest one, because the latest workflow run is not done yet. This may lead to incorrect results. Try to re-run all tests to get up to date results.

Path Size % Change Change
@sentry/browser 22.74 KB - -
@sentry/browser - with treeshaking flags 21.53 KB - -
@sentry/browser (incl. Tracing) 35.14 KB - -
@sentry/browser (incl. Tracing, Replay) 71.86 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.29 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 76.17 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 88.97 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.81 KB - -
@sentry/browser (incl. metrics) 26.99 KB - -
@sentry/browser (incl. Feedback) 39.89 KB - -
@sentry/browser (incl. sendFeedback) 27.39 KB - -
@sentry/browser (incl. FeedbackAsync) 32.18 KB - -
@sentry/react 25.5 KB - -
@sentry/react (incl. Tracing) 38.1 KB - -
@sentry/vue 26.89 KB - -
@sentry/vue (incl. Tracing) 37.02 KB - -
@sentry/svelte 22.88 KB - -
CDN Bundle 24.1 KB - -
CDN Bundle (incl. Tracing) 36.96 KB - -
CDN Bundle (incl. Tracing, Replay) 71.62 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 76.96 KB - -
CDN Bundle - uncompressed 70.64 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.71 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 222.23 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.45 KB - -
@sentry/nextjs (client) 38.18 KB - -
@sentry/sveltekit (client) 35.75 KB - -
@sentry/node 129.6 KB -0.01% -3 B 🔽
@sentry/node - without tracing 94.3 KB - -
@sentry/aws-serverless 105.17 KB -0.01% -4 B 🔽

View base workflow run

Copy link

codecov bot commented Oct 29, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
234 1 233 10
View the top 1 failed tests by shortest run time
client-app-routing-instrumentation.test.ts Creates a navigation transaction for app router routes
Stack Traces | 30s run time
client-app-routing-instrumentation.test.ts:19:5 Creates a navigation transaction for app router routes

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@s1gr1d s1gr1d force-pushed the sig/astro-waitUntil branch from aff106d to 005a1c1 Compare October 31, 2024 09:28
@s1gr1d s1gr1d merged commit 9444c9c into develop Oct 31, 2024
118 checks passed
@s1gr1d s1gr1d deleted the sig/astro-waitUntil branch October 31, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Astro server errors not reported when adapter is Vercel
2 participants