Skip to content

feat(node): fetch breadcrumbs without tracing #14018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 20 commits into from

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Oct 18, 2024

This PR adds the fetchBreadcrumbsIntegration and enables it by default. This integration captures fetch (and undici) breadcrumbs without the need to enable tracing.

Setting the fetchBreadcrumbs top-level init option to false disables this integration. I added a top-level config option because this integration is enabled by default and we like a simple way to disable it without resorting to filtering or passing integrations.

Breadcrumbs addition has been removed from nativeNodeFetchIntegration and its breadcrumbs option has been deprecated but to preserve backwards compatibility, this property also disables the new integration. There is a test to confirm this!

Copy link
Contributor

github-actions bot commented Oct 18, 2024

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.28 KB - -
@sentry/browser - with treeshaking flags 23.12 KB - -
@sentry/browser (incl. Tracing) 36.95 KB - -
@sentry/browser (incl. Tracing, Replay) 74.14 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 67.51 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 78.8 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 90.61 KB - -
@sentry/browser (incl. Feedback) 39.68 KB - -
@sentry/browser (incl. sendFeedback) 27.9 KB - -
@sentry/browser (incl. FeedbackAsync) 32.67 KB - -
@sentry/react 25.09 KB - -
@sentry/react (incl. Tracing) 38.87 KB - -
@sentry/vue 27.51 KB - -
@sentry/vue (incl. Tracing) 38.67 KB - -
@sentry/svelte 23.32 KB - -
CDN Bundle 24.51 KB - -
CDN Bundle (incl. Tracing) 36.95 KB - -
CDN Bundle (incl. Tracing, Replay) 71.99 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 77.16 KB - -
CDN Bundle - uncompressed 71.47 KB - -
CDN Bundle (incl. Tracing) - uncompressed 109.23 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 220.52 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 233.05 KB - -
@sentry/nextjs (client) 40.49 KB - -
@sentry/sveltekit (client) 37.39 KB - -
@sentry/node 142.81 KB -0.3% -428 B 🔽
@sentry/node - without tracing 96.03 KB -0.46% -451 B 🔽
@sentry/aws-serverless 120.35 KB -0.36% -434 B 🔽

View base workflow run

@timfish timfish self-assigned this Oct 18, 2024
@timfish timfish marked this pull request as ready for review October 24, 2024 09:20
@timfish timfish requested review from mydea and AbhiPrasad October 24, 2024 09:21
@timfish timfish closed this Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant