Skip to content

debug(replay): Add debugging statements around event buffer #14014

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 18, 2024
Merged

debug(replay): Add debugging statements around event buffer #14014

merged 3 commits into from
Oct 18, 2024

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Oct 17, 2024

This is not intended to be merged to prod, I would like to debug how/why
we keep hitting EventBuffer limits on Sentry SaaS. Aside from debugging
statements, there should be no other behavioral changes.

@billyvg billyvg changed the base branch from develop to beta October 17, 2024 20:09
@billyvg billyvg force-pushed the debug-replay-add-logs-to-debug-event-buffer-max-size branch 6 times, most recently from 2e97b79 to a8b0817 Compare October 17, 2024 20:15
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 17, 2024 •
edited
Loading

size-limit report 📦

Path Size % Change Change
@sentry/browser 22.74 KB added added
@sentry/browser - with treeshaking flags 21.53 KB added added
@sentry/browser (incl. Tracing) 35.01 KB added added
@sentry/browser (incl. Tracing, Replay) 71.95 KB added added
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.16 KB added added
@sentry/browser (incl. Tracing, Replay with Canvas) 76.29 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback) 89.06 KB added added
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 90.91 KB added added
@sentry/browser (incl. metrics) 27 KB added added
@sentry/browser (incl. Feedback) 39.88 KB added added
@sentry/browser (incl. sendFeedback) 27.38 KB added added
@sentry/browser (incl. FeedbackAsync) 32.18 KB added added
@sentry/react 25.49 KB added added
@sentry/react (incl. Tracing) 37.98 KB added added
@sentry/vue 26.91 KB added added
@sentry/vue (incl. Tracing) 36.9 KB added added
@sentry/svelte 22.87 KB added added
CDN Bundle 24.12 KB added added
CDN Bundle (incl. Tracing) 36.84 KB added added
CDN Bundle (incl. Tracing, Replay) 71.54 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) 76.86 KB added added
CDN Bundle - uncompressed 70.7 KB added added
CDN Bundle (incl. Tracing) - uncompressed 109.37 KB added added
CDN Bundle (incl. Tracing, Replay) - uncompressed 221.95 KB added added
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 235.16 KB added added
@sentry/nextjs (client) 37.95 KB added added
@sentry/sveltekit (client) 35.6 KB added added
@sentry/node 125.04 KB added added
@sentry/node - without tracing 94.14 KB added added
@sentry/aws-serverless 103.71 KB added added

@billyvg
debug(replay): Add debugging statements around event buffer
d7af0a9 
This is not intended to be merged to prod, I would like to debug how/why
we keep hitting EventBuffer limits on Sentry SaaS. Aside from debugging
statements, there should be no other behavioral changes.
@billyvg billyvg force-pushed the debug-replay-add-logs-to-debug-event-buffer-max-size branch from a8b0817 to d7af0a9 Compare October 17, 2024 20:26
@billyvg
Copy link
Member Author

billyvg commented Oct 17, 2024

Plan is to:

  • merge this to beta branch only
  • update beta branch w/ changes from develop + changelog,
  • deploy 8.35.0-beta.1

@billyvg billyvg marked this pull request as ready for review October 17, 2024 20:27
@billyvg billyvg requested a review from a team as a code owner October 17, 2024 20:27
c298lee
c298lee reviewed Oct 17, 2024
View reviewed changes
billyvg and others added 2 commits October 17, 2024 17:05
@billyvg @c298lee
Update packages/replay-internal/src/util/handleRecordingEmit.ts
5964c0f 
Co-authored-by: Catherine Lee <55311782+c298lee@users.noreply.github.com>
@billyvg
size limit :(
08cb6e7
@billyvg billyvg merged commit cd247f2 into beta Oct 18, 2024
137 of 138 checks passed
@billyvg billyvg deleted the debug-replay-add-logs-to-debug-event-buffer-max-size branch October 18, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c298lee c298lee c298lee approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@billyvg @c298lee