fix(normalize): Treat Infinity as NaN both are non-serializable numbers #13406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krystofwoldrich
requested review from
mydea,
AbhiPrasad and
a team
and removed request for
a team
11 tasks
size-limit report 📦
|
mydea
reviewed
Aug 27, 2024
mydea
reviewed
Aug 27, 2024
| @@ -224,6 +225,10 @@ function stringifyValue( | |||
| return '[NaN]'; | |||
| } | |||
|
|
|||
| if (typeof value === 'number' && !Number.isFinite(value)) { | |||
There was a problem hiding this comment.
actually, we can improve this even further :D we can combine this with the check above for nan, as (NaN).toString() also returns NaN. And isFinite(NaN) === false. So we can remove this completely:
if (typeof value === 'number' && value !== value) {
return '[NaN]';
}and only keep the new check you added!
mydea
approved these changes
Aug 28, 2024
krystofwoldrich
commented
Sep 10, 2024
| @@ -10,5 +10,5 @@ sentryTest('should set extras from multiple consecutive calls', async ({ getLoca | |||
| const eventData = await getFirstSentryEnvelopeRequest<Event>(page, url); | |||
|
|
|||
| expect(eventData.message).toBe('consecutive_calls'); | |||
| expect(eventData.extra).toMatchObject({ extra: [], Infinity: 2, null: null, obj: { foo: ['bar', 'baz', 1] } }); | |||
There was a problem hiding this comment.
The value under null key is Infinity
|
@krystofwoldrich this was released with https://github.com/getsentry/sentry-javascript/releases/tag/8.31.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RN SDK uses the normalize function before passing data over the RN Bridge, which only accepts serializable data.
Infinity causes -> getsentry/sentry-react-native#4024