Skip to content

compatible with wechat miniapp environment #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2018
Merged

compatible with wechat miniapp environment #1324

merged 1 commit into from
May 11, 2018

Conversation

exherb
Copy link
Contributor

@exherb exherb commented May 11, 2018

introduction

  • use _window.history instead of history (history is undefined in wechat miniapp environment)
  • use _navigator.userAgent instead of navigator (navigator is undefined in wechat miniapp environment)

Before submitting a pull request, please verify the following:

  • Ensure your code lints and the test suite passes (npm test).

@exherb
compatible with wechat miniapp environment
5eae0ea 
[introduction](https://developers.weixin.qq.com/miniprogram/introduction/)

- use _window.history instead of history (history is undefined in wechat miniapp environment)
- use _navigator.userAgent instead of navigator (navigator is undefined in wechat miniapp environment)
@exherb exherb requested a review from kamilogorek as a code owner May 11, 2018 01:11
@kamilogorek
Copy link
Contributor

Thanks @exherb!

@kamilogorek kamilogorek merged commit c26696a into getsentry:master May 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilogorek kamilogorek Awaiting requested review from kamilogorek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@exherb @kamilogorek