Handle JavaScript loaded in a blob

[kamilogorek]

Just ignore the SauceLabs. It's randomly failing due to timeouts, but I rebooted it few times and all browsers are green.

[kamilogorek]

@CaptObvious moved your commit to this PR so I could add tests and make some minor changes :)

[benvinegar]

Damn, nice.

[CaptObvious]

You could have done that in the previous PR - I had the setting enabled to allow maintainers to edit it.

Out of curiousity, why .slice() over .substr()?

[kamilogorek]

You could have done that in the previous PR - I had the setting enabled to allow maintainers to edit it.

I don't like to force push to someone else's forks and I had to do this, as I rebased some changes from master. Commit is still authored as yours though :)

Out of curiousity, why .slice() over .substr()?

substr cannot accept negative ranges, as slice do, which is imo more descriptive. Eg. slice(-300) is a simple "give me last 300 characters", where substr(value.length - 300) sounds more like a "give me all the characters that are left, starting at position 300 counting from the end of the value length".
I just find it easier to read :)

[CaptObvious]

I don't like to force push to someone else's forks and I had to do this, as I rebased some changes from master. Commit is still authored as yours though :)

Fair enough :)

substr cannot accept negative ranges, as slice do, which is imo more descriptive. Eg. slice(-300) is a simple "give me last 300 characters", where substr(value.length - 300) sounds more like a "give me all the characters that are left, starting at position 300 counting from the end of the value length".
I just find it easier to read :)

Good tip, thanks! I'm fairly new to JS so I'm still in the "whatever works" phase.

[CaptObvious]

You spotted where I got 300 from, nice 👍

[kamilogorek]

Haha, I'm surprised you found it! :D

[MaxBittker]

yeah, nice work @CaptObvious

[kamilogorek]

@CaptObvious released as 3.25.0