ci: Only run affected unit tests on PRs #13052
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
force-pushed
the
fn/unit-tests-affected
branch
from
2d1a4ad to
d164c7a
Compare
mydea
force-pushed
the
fn/unit-tests-affected
branch
from
5d8543e to
125a3f5
Compare
mydea
commented
Aug 1, 2024
| @@ -434,6 +434,11 @@ jobs: | |||
| timeout-minutes: 10 | |||
| runs-on: ubuntu-20.04 | |||
| steps: | |||
| - name: Check out base commit (${{ github.event.pull_request.base.sha }}) | |||
There was a problem hiding this comment.
Need to check this out here so we can use it to get changed files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates our unit test runner on CI to only run unit tests for packages that have been changed.
In addition, it also updates the list of packages to run in node/browser only unit test envs - we've been running some in both. We only actually need to run the fully-browser-only unit tests in the "Browser Unit Tests" job, the rest (including e.g. core, ...) runs in the node unit tests in all node versions.
In a follow up step, maybe we can further streamline this and simply run only unit tests and ensure that e.g. the browser ones only run in one of the node versions, not all of them. Or find another way that does not require us to keep 2 lists of packages in separate places. But for now, this should be an improvement.
I opened a test PR to show this in action, where only something in the react package was changed: