ref(e2e-tests): Make startCommand optional in shared playwright config
#12842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreiborza
approved these changes
Jul 10, 2024
mydea
reviewed
Jul 10, 2024
|
|
||
| // Fix urls not resolving to localhost on Node v17+ | ||
| // See: https://github.com/axios/axios/issues/3821#issuecomment-1413727575 | ||
| import { setDefaultResultOrder } from 'dns'; |
Member
There was a problem hiding this comment.
I think we can also get rid of these lines here!
mydea
reviewed
Jul 10, 2024
|
|
||
| // Fix urls not resolving to localhost on Node v17+ | ||
| // See: https://github.com/axios/axios/issues/3821#issuecomment-1413727575 | ||
| import { setDefaultResultOrder } from 'dns'; |
Member
There was a problem hiding this comment.
I think we can get rid of this too!
mydea
approved these changes
Jul 10, 2024
AbhiPrasad
approved these changes
Jul 11, 2024
Contributor
size-limit report 📦
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small refactor:
Not all our e2e tests require a
startCommandas we sometimes directly invoke an application from within tests. For example in our AWS lambda e2e tests. This PR makes thestartCommandoption optional so that we can avoid a larger override of the entirewebServerplaywright config object.