-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(feedback): Add reason
argument to onFormClose
callback
#12811
base: develop
Are you sure you want to change the base?
Conversation
3590265
to
d916488
Compare
size-limit report 📦
|
reason
argument to onFormClose callbackreason
argument to onFormClose
callback
@@ -16,6 +16,21 @@ export default [ | |||
}, | |||
}), | |||
), | |||
...makeBundleConfigVariants( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's this needed for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops, this isn't needed. I think it's leftover when i was playing with bundle-size measurements. This isn't a real bundle that we should be shipping.
@@ -2,7 +2,7 @@ import type { Integration } from '@sentry/types'; | |||
import { consoleSandbox } from '@sentry/utils'; | |||
import { FAKE_FUNCTION } from './common'; | |||
|
|||
const FEEDBACK_INTEGRATION_METHODS = ['attachTo', 'createWidget', 'remove'] as const; | |||
const FEEDBACK_INTEGRATION_METHODS = ['attachTo', 'createForm', 'createWidget', 'remove'] as const; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shim was missing before, nice to get it in
Adds a
reason
argument toonFormClose
so folks can tell the difference between users who've clicked the intentional "Cancel" button, vs. clicks outside of the feedback form which might've unintentionally hidden the form.Relates to #12812