Skip to content

fix(profiling): continuous profile chunks should be in seconds #12532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Jun 18, 2024

Timestamps reported in the chunk format need to be in seconds

@JonasBa JonasBa requested a review from Zylphrex June 18, 2024 20:14
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get this release tomorrow.

@JonasBa JonasBa force-pushed the jb/profiling/timestamp-seconds branch from c4a350c to 1e71d15 Compare June 18, 2024 20:19
@JonasBa
Copy link
Member Author

JonasBa commented Jun 18, 2024

We can get this release tomorrow.

That would be great ❤️ I'm trying to get some profiles from chartcuterie so we can validate the SDKs are good and can focus on the UI. The next part after that is to port this to the browsers SDK as well so we can finally move away from mostly profiling pageloads

Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 22.03 KB (0%)
@sentry/browser (incl. Tracing) 33.2 KB (0%)
@sentry/browser (incl. Tracing, Replay) 68.97 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.29 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.04 KB (+0.05% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.2 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87.02 KB (+0.01% 🔺)
@sentry/browser (incl. metrics) 26.21 KB (0%)
@sentry/browser (incl. Feedback) 38.24 KB (0%)
@sentry/browser (incl. sendFeedback) 26.65 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.22 KB (0%)
@sentry/react 24.77 KB (0%)
@sentry/react (incl. Tracing) 36.25 KB (0%)
@sentry/vue 26.03 KB (0%)
@sentry/vue (incl. Tracing) 35.06 KB (0%)
@sentry/svelte 22.17 KB (0%)
CDN Bundle 23.36 KB (0%)
CDN Bundle (incl. Tracing) 34.89 KB (0%)
CDN Bundle (incl. Tracing, Replay) 69.02 KB (+0.05% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.2 KB (+0.02% 🔺)
CDN Bundle - uncompressed 68.68 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 103.29 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 213.76 KB (+0.01% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 226.35 KB (+0.01% 🔺)
@sentry/nextjs (client) 36.14 KB (0%)
@sentry/sveltekit (client) 33.83 KB (0%)
@sentry/node 112.67 KB (0%)
@sentry/node - without tracing 90.07 KB (0%)
@sentry/aws-serverless 99.16 KB (0%)

@JonasBa JonasBa enabled auto-merge (squash) June 18, 2024 20:39
@JonasBa JonasBa merged commit e9e862f into develop Jun 18, 2024
140 checks passed
@JonasBa JonasBa deleted the jb/profiling/timestamp-seconds branch June 18, 2024 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants