Skip to content

feat(node) add max lineno and colno limits #12514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 27 commits into from
Jun 17, 2024
Merged

Conversation

JonasBa
Copy link
Member

@JonasBa JonasBa commented Jun 17, 2024

We want to have some safeguards in place to avoid reading minified files or large bundled files as we could incur a large processing time cost. The output of such files is likely to be less useful anyways, so contextlines would be low value

@JonasBa JonasBa requested a review from AbhiPrasad June 17, 2024 15:27
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Base automatically changed from jb/node/contextlines-memory to develop June 17, 2024 15:34
Copy link
Contributor

github-actions bot commented Jun 17, 2024

size-limit report 📦

Path Size
@sentry/browser 22.03 KB (0%)
@sentry/browser (incl. Tracing) 33.2 KB (0%)
@sentry/browser (incl. Tracing, Replay) 68.94 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 62.27 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 73.01 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 85.18 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay, Feedback, metrics) 87 KB (+0.01% 🔺)
@sentry/browser (incl. metrics) 26.21 KB (0%)
@sentry/browser (incl. Feedback) 38.22 KB (+0.01% 🔺)
@sentry/browser (incl. sendFeedback) 26.62 KB (0%)
@sentry/browser (incl. FeedbackAsync) 31.17 KB (0%)
@sentry/react 24.8 KB (0%)
@sentry/react (incl. Tracing) 36.28 KB (0%)
@sentry/vue 26.03 KB (0%)
@sentry/vue (incl. Tracing) 35.06 KB (0%)
@sentry/svelte 22.17 KB (0%)
CDN Bundle 23.36 KB (0%)
CDN Bundle (incl. Tracing) 34.89 KB (0%)
CDN Bundle (incl. Tracing, Replay) 68.99 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.16 KB (0%)
CDN Bundle - uncompressed 68.68 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 103.29 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 213.74 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 226.2 KB (0%)
@sentry/nextjs (client) 35.61 KB (0%)
@sentry/sveltekit (client) 33.83 KB (0%)
@sentry/node 112.7 KB (+0.03% 🔺)
@sentry/node - without tracing 90.11 KB (+0.05% 🔺)
@sentry/aws-serverless 99.2 KB (+0.04% 🔺)

@JonasBa JonasBa force-pushed the jb/node/contextlines-limits branch from 5a98514 to e82c510 Compare June 17, 2024 15:56
@JonasBa JonasBa merged commit e77cb8f into develop Jun 17, 2024
98 checks passed
@JonasBa JonasBa deleted the jb/node/contextlines-limits branch June 17, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants