feat(feedback): Improve screenshot quality for retina displays #12487
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
approved these changes
Jun 17, 2024
billyvg
approved these changes
Jun 17, 2024
packages/feedback/src/screenshot/components/ScreenshotEditor.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves screenshot quality after cropping for retina displays. This increases resolution after cropping by factoring in DPI.
Before:
After:
The size is the same when cropping but when viewing feedbacks, screenshots from retina displays are twice as large due to higher DPI.
Closes #12329