feat(core): Ignore additional common but inactionable errors #12384
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
mydea
reviewed
Jun 6, 2024
| /^ResizeObserver loop completed with undelivered notifications.$/, // The browser logs this when a ResizeObserver handler takes a bit longer. Usually this is not an actual issue though. It indicates slowness. | ||
| /^Cannot redefine property: googletag$/, // This is thrown when google tag manager is used in combination with an ad blocker | ||
| "undefined is not an object (evaluating 'a.L')", // Random error that happens but not actionable or noticeable to end-users. | ||
| 'can\'t redefine non-configurable property "solana"', // Probably a browser extension or custom browser (Brave) throwing this error |
There was a problem hiding this comment.
not 100% sure, this appears pretty specific, but no strong feelings, also OK to keep it here :)
There was a problem hiding this comment.
These things being specific is good :D. This particular error is in 647 projects, which is way too many to be actual application code. I am pretty sure this is brave doing things.
mydea
approved these changes
Jun 6, 2024
billyvg
pushed a commit
that referenced
this pull request
Jun 10, 2024
This was referenced Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a few errors to our default ignore list that we have identified analyzing incoming events on Sentry:
undefined is not an object (evaluating 'a.L'): 2250 projects, 12598 issuescan\'t redefine non-configurable property "solana": 647 projects, 1600 issuesvv().getRestrictions is not a function. (In 'vv().getRestrictions(1,a)', 'vv().getRestrictions' is undefined): 612 projects, 1555 issuesCan't find variable: _AutofillCallbackHandler: 447 projects, 4135 issues