-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(browser): Do not include metrics in base CDN bundle #12230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed to the change; on the contrary - whatever helps shrinking the bytes for the base bundle.
Just wondering if it's correct to couple metrics to the performance bundles since product-wise metrics isn't strictly tied to performance 🤔 Maybe it's good enough for now though. wdyt?
size-limit report 📦
|
Yeah, I know what you mean. IMHO we have a few options here:
Personally I'd go with 1. for now and possibly extend with 3 if we find out it's a problem/there is a need for that? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally I'd go with 1. for now and possibly extend with 3 if we find out it's a problem/there is a need for that?
Yup, sounds fair to me!
09721ce
to
293bdc1
Compare
Metrics are only included when performance is included, reducing the base bundle size. We always expose a shim so there is no API breakage, it just does nothing.
ef40480
to
246f159
Compare
Metrics are only included when performance is included, reducing the base bundle size.
We always expose a shim so there is no API breakage, it just does nothing.
I noticed this while working on #12226.