Skip to content

fix(nextjs): Use global scope for generic event filters #12205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 24, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented May 24, 2024

While doing #12194 I noticed that there were some inconsistencies with how the generic event processors were running in nextjs and I think it might be because we are attaching to an isolation scope instead of a global scope.

@lforst lforst requested a review from mydea May 24, 2024 09:23
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser 21.74 KB (0%)
@sentry/browser (incl. Tracing) 32.77 KB (-0.36% 🔽)
@sentry/browser (incl. Tracing, Replay) 68.23 KB (-0.03% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.64 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.27 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.31 KB (-0.04% 🔽)
@sentry/browser (incl. Feedback) 37.75 KB (0%)
@sentry/browser (incl. sendFeedback) 26.31 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.73 KB (0%)
@sentry/react 24.43 KB (0%)
@sentry/react (incl. Tracing) 35.75 KB (-0.35% 🔽)
@sentry/vue 25.68 KB (0%)
@sentry/vue (incl. Tracing) 34.58 KB (-0.35% 🔽)
@sentry/svelte 21.88 KB (0%)
CDN Bundle 24.28 KB (0%)
CDN Bundle (incl. Tracing) 34.22 KB (-0.36% 🔽)
CDN Bundle (incl. Tracing, Replay) 68.02 KB (-0.04% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) 73.01 KB (-0.03% 🔽)
CDN Bundle - uncompressed 71.46 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 101.55 KB (-0.32% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed 211.43 KB (-0.03% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 223.79 KB (-0.03% 🔽)
@sentry/nextjs (client) 35.12 KB (-0.06% 🔽)
@sentry/sveltekit (client) 33.36 KB (-0.37% 🔽)
@sentry/node 114.32 KB (0%)
@sentry/aws-serverless 103.2 KB (-0.01% 🔽)

@lforst lforst merged commit 3ea5373 into develop May 24, 2024
75 checks passed
@lforst lforst deleted the lforst-use-global-scope branch May 24, 2024 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants