objectMerge Add to trimHeadFrames if capturing new trace

[leth]

Otherwise the original trim value will be off by one.

[kamilogorek]

Can we set the default for options at the top of the method while also making a copy?

options = options ? Object.merge({}, options) : {}

and then just leave (options.trimHeadFrames || 0) + 1?

We also don't need a double objectMerge, as it can be done in a single call when we do so:

objectMerge(options, {
  stacktrace: true,
  trimHeadFrames: (options.trimHeadFrames || 0) + 1
})

Although I'm not sure if we cannot just reverse it, even though it's reference and write

objectMerge(options, {
  stacktrace: true,
  trimHeadFrames: (options.trimHeadFrames || 0) + 1
})

without making a copy, as objectMerge is just reassigning values by key anyway.

[leth]

Sounds like a good idea! Thanks!

[kamilogorek]

You missed a comma after stacktrace: true, therefore all tests fail :P

  423:13  error  Parsing error: Unexpected token trimHeadFrames

[kamilogorek]

Fixed it myself and rebase manually. Thanks! :)

[leth]

Sorry, thanks for picking that up!

[leth]

I can't see this fix on any of the active branches... did it get lost?

[kamilogorek]

50beaa5 first at the top. I'll make a release within next 20-30min.

[kamilogorek]

Released as 3.22.2

[leth]

Awesome, thanks!