Skip to content

fix(nextjs): Fix legacy configuration method detection for emitting warning #12136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 21, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented May 21, 2024

Our logic to detect whether the user used the legacy way of initializing the sdk had a flaw because the heuristic to check whether the user has an instrumentation file with sentry config was matching for sentry.server.config.ts instead of sentry.server.config, which would be the way users import their config files.

@lforst lforst marked this pull request as ready for review May 21, 2024 11:15
@lforst lforst requested review from mydea, Lms24 and AbhiPrasad May 21, 2024 11:15
@lforst lforst merged commit 85db0de into develop May 21, 2024
73 checks passed
@lforst lforst deleted the lforst-fix-legacy-detection branch May 21, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants