fix(browser): Continuously record CLS web vital #11934
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Through debugging I found that we were only recording the CLS web vital when we were hiding the tab (so either when switching tabs or when unloading the page).
This is problematic because it result in us not sending CLS values for pageloads at all (or at least with really low probability). We fix this by setting
reportAllChanges: true
which will continuously update the CLS metric before we send it.