Skip to content

fix(feedback): Pick user from any scope #11928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 7, 2024
Merged

fix(feedback): Pick user from any scope #11928

merged 1 commit into from
May 7, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented May 7, 2024

The user can be set on any scope, we should pick it correctly from wherever it is set.

@mydea mydea requested review from lforst, s1gr1d and andreiborza May 7, 2024 07:18
@mydea mydea self-assigned this May 7, 2024
@mydea mydea requested a review from a team as a code owner May 7, 2024 07:18
Copy link
Contributor

github-actions bot commented May 7, 2024

size-limit report 📦

Path Size
@sentry/browser 21.65 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing) 32.67 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) 68.01 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.41 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.05 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.14 KB (-0.02% 🔽)
@sentry/browser (incl. Feedback) 37.66 KB (-0.02% 🔽)
@sentry/browser (incl. sendFeedback) 26.21 KB (-0.01% 🔽)
@sentry/browser (incl. FeedbackAsync) 30.84 KB (-0.01% 🔽)
@sentry/react 24.33 KB (-0.01% 🔽)
@sentry/react (incl. Tracing) 35.63 KB (-0.01% 🔽)
@sentry/vue 25.48 KB (-0.01% 🔽)
@sentry/vue (incl. Tracing) 34.46 KB (-0.01% 🔽)
@sentry/svelte 21.78 KB (-0.01% 🔽)
CDN Bundle 24.13 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing) 34.04 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing, Replay) 67.71 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) 72.92 KB (-0.01% 🔽)
CDN Bundle - uncompressed 70.99 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing) - uncompressed 100.98 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.58 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 223.87 KB (-0.01% 🔽)
@sentry/nextjs (client) 34.86 KB (-0.01% 🔽)
@sentry/sveltekit (client) 33.23 KB (-0.01% 🔽)
@sentry/node 146.27 KB (-0.02% 🔽)

@mydea mydea force-pushed the fn/feedback-user branch from bf4eb1d to fc4859f Compare May 7, 2024 07:51
@mydea mydea merged commit 3804ff0 into develop May 7, 2024
185 checks passed
@mydea mydea deleted the fn/feedback-user branch May 7, 2024 13:19
andreiborza pushed a commit that referenced this pull request May 16, 2024
The user can be set on any scope, we should pick it correctly from
wherever it is set.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants