-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat(node): Warn if ESM mode is detected #11914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We won't support ESM at all for now with Node v8?
Do we not want to mention the lack of autoinstrumentation with ESM and/or point them towards some docs? |
We will, but today we basically don't support it because of broken import-in-the-middle. A fix for that is pending and should be released this week (hopefully), then we'll update this accordingly! |
@mydea is there an issue tracking the ESM fix you referenced? We would like to adopt sentry, but will not even attempt until the SDK is ESM compatible. 🙏🏻 |
Also wondering if there is an issue to track ESM compatibility? |
Just to be clear, if you're using ESM and have a build step (i.e. a bundler, running it through tsc, etc) you should be fine. This issue is for pure ESM setups. |
Amazing, thank you for the clarification. We have spent the whole week on our ESM migration so trying to get things tied out. But... there also seems to be a bug: #11965 🙏🏻 |
This prints a console.warn out if we detect that we are running in ESM mode.