fix(node): Ensure prisma integration creates valid DB spans #11908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
commented
May 6, 2024
| @@ -13,6 +13,19 @@ const _prismaIntegration = (() => { | |||
| new prismaInstrumentation.PrismaInstrumentation({}), | |||
| ); | |||
| }, | |||
|
|
|||
| setup(client) { | |||
| client.on('spanStart', span => { | |||
There was a problem hiding this comment.
Sadly we have no hook in the integration for this, but I think this is OK - as this integration is opt-in anyhow (as of now, at least), there is no overhead if not using this.
There was a problem hiding this comment.
Possible improvement for this: We could PR this upstream to have a proper hook for this...
lforst
approved these changes
May 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11891