Skip to content

test: Remove getLocalTestPath #11904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

test: Remove getLocalTestPath #11904

wants to merge 6 commits into from

Conversation

mydea
Copy link
Member

@mydea mydea commented May 6, 2024

Just use getLocalTestUrl everywhere, which is actually closer to reality.

@mydea mydea requested review from lforst and s1gr1d May 6, 2024 06:22
@mydea mydea self-assigned this May 6, 2024
@mydea mydea requested a review from a team as a code owner May 6, 2024 06:23
@billyvg
Copy link
Member

billyvg commented May 6, 2024

The tests that are failing seem to be caused due to CI/build issue from feedback package -> #11902

@mydea mydea force-pushed the fn/remove-testpath branch from 0337951 to 3b542c9 Compare May 28, 2024 09:46
mydea added 6 commits August 6, 2024 08:49
@mydea
test: Remove getLocalTestPath
e05cc2b 
Just use `getLocalTestUrl` everywhere, which is actually closer to reality.
@mydea
fix test
4f7091a
@mydea
unflake tests???
a5a3c0c
@mydea
fix new test
cf2978b
@mydea
fix stuff
d71532b
@mydea
WIP
3fa1cf5
@mydea mydea force-pushed the fn/remove-testpath branch from a409711 to 3fa1cf5 Compare August 6, 2024 06:54
@lforst lforst removed their request for review October 23, 2024 07:31
@mydea mydea mentioned this pull request Nov 15, 2024
Merged
mydea added a commit that referenced this pull request Nov 18, 2024
@mydea
test(browser): Update tests that need changes for getLocalTestUrl (#…
a374baf 
…14324)

Extracted these out of
#11904 - these are
all the tests that required changing any (test) code for them to pass
with `getLocalTestUrl` vs `getLocalTestPath`.
@mydea mydea closed this Nov 18, 2024
@mydea mydea deleted the fn/remove-testpath branch November 18, 2024 08:39
onurtemizkan pushed a commit that referenced this pull request Nov 22, 2024
@mydea @onurtemizkan
test(browser): Update tests that need changes for getLocalTestUrl (#…
1c69e8a 
…14324)

Extracted these out of
#11904 - these are
all the tests that required changing any (test) code for them to pass
with `getLocalTestUrl` vs `getLocalTestPath`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@s1gr1d s1gr1d s1gr1d approved these changes

Assignees

@mydea mydea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mydea @billyvg @s1gr1d