Skip to content

feat(nextjs): Be smarter in warning about old ways of init configuration #11882

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2024

Conversation

lforst
Copy link
Contributor

@lforst lforst commented May 3, 2024

In theory it is possible that people still have files like sentry.server.config.ts and reference them from instrumentation.ts. In that case we do not want to show the warning about the old way.

@lforst lforst requested review from mydea, Lms24 and s1gr1d May 3, 2024 08:41
Copy link
Contributor

github-actions bot commented May 3, 2024

size-limit report 📦

Path Size
@sentry/browser 21.65 KB (0%)
@sentry/browser (incl. Tracing) 32.67 KB (-0.05% 🔽)
@sentry/browser (incl. Tracing, Replay) 68.01 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.41 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 72.05 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing, Replay, Feedback) 84.18 KB (-0.03% 🔽)
@sentry/browser (incl. Feedback) 37.69 KB (0%)
@sentry/browser (incl. sendFeedback) 26.21 KB (0%)
@sentry/browser (incl. FeedbackAsync) 30.77 KB (0%)
@sentry/react 24.33 KB (0%)
@sentry/react (incl. Tracing) 35.63 KB (-0.05% 🔽)
@sentry/vue 25.48 KB (0%)
@sentry/vue (incl. Tracing) 34.46 KB (-0.04% 🔽)
@sentry/svelte 21.78 KB (0%)
CDN Bundle 24.03 KB (0%)
CDN Bundle (incl. Tracing) 34.04 KB (-0.05% 🔽)
CDN Bundle (incl. Tracing, Replay) 67.7 KB (-0.05% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) 72.82 KB (-0.04% 🔽)
CDN Bundle - uncompressed 70.64 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 100.93 KB (-0.08% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed 210.54 KB (-0.04% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 223.58 KB (-0.04% 🔽)
@sentry/nextjs (client) 34.86 KB (-0.04% 🔽)
@sentry/sveltekit (client) 33.23 KB (-0.04% 🔽)
@sentry/node 138.72 KB (0%)

@mydea mydea merged commit 5102de0 into develop May 3, 2024
70 checks passed
@mydea mydea deleted the lforst-smarter-warning-logic branch May 3, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants