feat(ioredis): Add integration for ioredis
#11856
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s1gr1d
commented
Apr 30, 2024
packages/node/package.json
Outdated
Comment on lines
74
to
75
| "@opentelemetry/instrumentation-redis": "0.39.0", | ||
| "@opentelemetry/instrumentation-redis-4": "0.39.0", |
There was a problem hiding this comment.
The packages are added, but not yet instrumented. Those are yet to be implemented in another PR.
There was a problem hiding this comment.
let's not add them yet, let's just add them when we introduce the respective integration!
size-limit report 📦
|
mydea
reviewed
May 2, 2024
packages/node/package.json
Outdated
Comment on lines
74
to
75
| "@opentelemetry/instrumentation-redis": "0.39.0", | ||
| "@opentelemetry/instrumentation-redis-4": "0.39.0", |
There was a problem hiding this comment.
let's not add them yet, let's just add them when we introduce the respective integration!
| * | ||
| * Capture tracing data for redis and ioredis. | ||
| */ | ||
| export const experimental_redisIntegration = defineIntegration(_redisIntegration); |
There was a problem hiding this comment.
let's drop the experimental_ part, this is not any more or less experimental as our other integrations :D let's just ship this!
mydea
reviewed
May 2, 2024
| @@ -351,6 +351,7 @@ We now support the following integrations out of the box without extra configura | |||
| - `mongooseIntegration`: Automatically instruments Mongoose | |||
| - `mysqlIntegration`: Automatically instruments MySQL | |||
| - `mysql2Integration`: Automatically instruments MySQL2 | |||
| - `redisIntegration`: Automatically instruments Redis (supported clients: ioredis) | |||
mydea
reviewed
May 2, 2024
Co-authored-by: Francesco Novy <francesco.novy@sentry.io>
mydea
changed the title
mydea
changed the title
ioredis
mydea
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration for Node
integrations: [Sentry.experimental_redisIntegration()]