feat(feedback): Have screenshot by default #11839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
reviewed
Apr 30, 2024
| @@ -64,7 +64,7 @@ export const buildFeedbackIntegration = ({ | |||
| autoInject = true, | |||
| showEmail = true, | |||
| showName = true, | |||
| showScreenshot = false, | |||
| showScreenshot = true, | |||
There was a problem hiding this comment.
Just to clarify, with the current state of things, this will lazy load the screenshots integration unless it is already installed, both on NPM & CDN?
There was a problem hiding this comment.
Maybe @ryan953 can confirm, but yes I think so. Is that not something we want to do?
There was a problem hiding this comment.
Before #11791 we're shipping the sync strategy using the name feedbackIntegration in all places.
Long term, #11791 sets things up. From that PR:
packages/browser/src/index.tsis returningfeedbackSyncIntegration as feedbackIntegration, so that should be the Sync strategy for NPM users, by default. But both strats are available.index.bundle.*(there are two) returningfeedbackAsyncIntegration as feedbackIntegration,which is the async strategy, sync is not available (we'd need another bundle build to do that)
ryan953
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defaults to having screenshots.