Skip to content

test(svelte): Add Svelte 5 E2E test app #11814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Conversation

Lms24
Copy link
Member

@Lms24 Lms24 commented Apr 26, 2024

In #11807 I added a SvelteKit+Svelte 5 E2E test. Let's also add a small Svelte 5 standalone/SPA app ensure we cover such apps as well.

Update: Turns out it was a good idea to add this test app because the app is running in Runes mode, as opposed to the SvelteKit+Svelte 5 app. Turns out, In Svelte 5 Runes mode, we can't track component updates anymore. Because of this limitation users would get a build error if they don't explicitly disable tracking component updates. I'll think about how we can solve this properly on Monday.

Until then, the workaround will be to just disable tracking component updates:

// svelte.config.js
const configWithSentry = withSentryConfig(config, {
  componentTracking: { 
    trackUpdates: false,  // <-- disable tracking updates
    trackComponents: true, 
    trackInit: true 
  },
});

@Lms24 Lms24 requested review from AbhiPrasad and mydea April 26, 2024 14:44
@Lms24 Lms24 merged commit 43e370f into develop Apr 26, 2024
@Lms24 Lms24 deleted the lms/test-e2e-svelte-5-app branch April 26, 2024 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants