Skip to content

feat(opentelemetry): Update OTEL packages & relax some version ranges #11580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 16, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 12, 2024

This bumps all our OTEL dependencies to require the most up to date versions as of today for all the core packages.

This allows us to use the new semantic attributes, which esp. also some instrumentation uses in newer versions. By requiring this as a minimum version, we can ensure that we can update all our instrumentation.

This also relaxes all of the core packages to ^ range, so users can easier use @sentry/node together with their own otel instrumentation. The instrumentation we add remains hard-pinned.

To avoid deprecation warnings I updated all the semantic attributes usage to the new syntax.

@mydea mydea requested review from lforst, Lms24, AbhiPrasad and s1gr1d April 12, 2024 13:41
@mydea mydea self-assigned this Apr 12, 2024
Copy link
Contributor

github-actions bot commented Apr 12, 2024

size-limit report 📦

Path Size
@sentry/browser 21.67 KB (0%)
@sentry/browser (incl. Tracing) 31.28 KB (0%)
@sentry/browser (incl. Tracing, Replay) 66.59 KB (0%)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 59.99 KB (0%)
@sentry/browser (incl. Tracing, Replay with Canvas) 70.43 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) 80.28 KB (0%)
@sentry/browser (incl. Feedback) 35.24 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal) 35.25 KB (0%)
@sentry/browser (incl. Feedback, Feedback Modal, Feedback Screenshot) 37.27 KB (0%)
@sentry/browser (incl. sendFeedback) 26.46 KB (0%)
@sentry/react 24.35 KB (0%)
@sentry/react (incl. Tracing) 34.17 KB (0%)
@sentry/vue 25.2 KB (0%)
@sentry/vue (incl. Tracing) 32.99 KB (0%)
@sentry/svelte 21.79 KB (0%)
CDN Bundle 24.03 KB (0%)
CDN Bundle (incl. Tracing) 32.58 KB (0%)
CDN Bundle (incl. Tracing, Replay) 66.22 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 82.4 KB (0%)
CDN Bundle - uncompressed 70.86 KB (0%)
CDN Bundle (incl. Tracing) - uncompressed 96.98 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 206.64 KB (0%)
@sentry/nextjs (client) 33.51 KB (0%)
@sentry/sveltekit (client) 31.77 KB (0%)
@sentry/node 136.26 KB (+9.68% 🔺)

@mydea mydea force-pushed the fn/relax-otel-deps branch 3 times, most recently from 1a8426a to 2c9b95f Compare April 15, 2024 12:36
Also relaxe the ranges for `@sentry/node` to not require strict dependencies for the core packages. For instrumentation, we continue to have stricter dependencies.
@mydea mydea force-pushed the fn/relax-otel-deps branch from 99ea303 to 69619f0 Compare April 16, 2024 15:26
@AbhiPrasad
Copy link
Member

Going to merge this in to remove some merge conflicts with my upcoming otel related PR

@AbhiPrasad AbhiPrasad merged commit 8b6f838 into develop Apr 16, 2024
@AbhiPrasad AbhiPrasad deleted the fn/relax-otel-deps branch April 16, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants