feat(sveltekit): Update scope transactionName when handling server-side request #11511
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
force-pushed
the
lms/feat-sveltekit-server-update-scope-transactionname
branch
from
13c44c6 to
2f6a459
Compare
size-limit report 📦
|
mydea
approved these changes
Apr 9, 2024
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
…de request (getsentry#11511) Update the scope's `transactionName` in the `sentryHandle` instrumentation that's always invoked when a request is made to the SvelteKit server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the scope's
transactionNamein thesentryHandleinstrumentation that's always invoked when a request is made to the SvelteKit server.For now, I opted to not set the transactionName to unknown route URLs by default (i.e. a request that doesn't match a known server endpoint/route). Users can opt into also handling unknown routes at which point we'll also set the transactionName for such routes.
ref #10846