ref(nextjs): Replace multiplexer with conditional exports #11442
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lforst
changed the title
@vercel/otel
lforst
changed the title
AbhiPrasad
approved these changes
Apr 5, 2024
| "default": "./build/esm/edge/index.js" | ||
| }, | ||
| "workerd": { | ||
| "default": "./build/esm/edge/index.js" |
There was a problem hiding this comment.
Fair point, in general I think nextjs can cope with only having esm but I'm gonna try to add cjs exports too.
cadesalaberry
pushed a commit
to cadesalaberry/sentry-javascript
that referenced
this pull request
Apr 19, 2024
jigsawye
reviewed
May 20, 2024
| "browser": { | ||
| "import": "./build/esm/index.client.js", | ||
| "require": "./build/cjs/index.client.js" | ||
| }, | ||
| "node": "./build/cjs/index.server.js", | ||
| "import": "./build/esm/index.server.js", |
There was a problem hiding this comment.
Hi @lforst
I noticed in this PR that node exports take precedence over import. Is this expected? This causes the resolution to always fall back to the CommonJS version in a Node environment, regardless of whether ESM is used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can replace the SDK multiplexer with conditional exports. I found this while preparing the Next.js SDK for using
@vercel/otel.This is preferrable over the current solution because the loaders will not work any longer with turbopack.