Skip to content

ref(tracing): Remove span.startChild() #11376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2024
Merged

ref(tracing): Remove span.startChild() #11376

merged 2 commits into from
Apr 3, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 2, 2024

Also refactor the span logging behavior into a logging integration, to make this consistent between core & otel-powered spans.

@mydea mydea self-assigned this Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Bundle Report

Changes will increase total bundle size by 982 bytes ⬆️

Bundle name Size Change
@sentry-internal/replay-cjs 306.35kB 0 bytes
@sentry/types-cjs 35 bytes 0 bytes
@sentry-internal/replay-canvas-cjs 29.51kB 0 bytes
@sentry/aws-serverless-cjs 14.62kB 5.67kB ⬇️
@sentry-internal/replay-esm 306.46kB 0 bytes
@sentry-internal/node-integration-tests-cjs 1.04kB 0 bytes
@sentry-internal/node-integration-tests-esm 888 bytes 0 bytes
@sentry-internal/replay-canvas-esm 29.43kB 0 bytes
@sentry/bun-cjs 13.6kB 94 bytes ⬆️
@sentry/node-cjs 336.28kB 94 bytes ⬆️
@sentry/sveltekit-cjs 69.31kB 0 bytes
@sentry/types-esm 35 bytes 0 bytes
@sentry/browser-esm 104.65kB 126 bytes ⬆️
@sentry/wasm-cjs 5.2kB 0 bytes
@sentry/remix-cjs 53.62kB 0 bytes
@sentry/google-cloud-serverless-cjs 23.07kB 60 bytes ⬆️
@sentry/google-cloud-serverless-esm 19.18kB 23 bytes ⬆️
@sentry/bun-esm 10.13kB 75 bytes ⬆️
@sentry/sveltekit-esm 61.08kB 0 bytes
@sentry/utils-cjs 178.16kB 0 bytes
@sentry/remix-esm 48.23kB 0 bytes
@sentry/gatsby-esm 385 bytes 0 bytes
@sentry/node-esm 332.86kB 75 bytes ⬆️
@sentry/browser-cjs 107.51kB 145 bytes ⬆️
@sentry/nextjs-esm 20.02kB 7.49kB ⬆️
@sentry/astro-cjs 27.13kB 0 bytes
@sentry/utils-esm 173.58kB 0 bytes
@sentry/gatsby-cjs 905 bytes 0 bytes
@sentry/svelte-cjs 13.84kB 0 bytes
@sentry/nextjs-cjs 20.52kB 0 bytes
@sentry/vue-cjs 20.19kB 0 bytes
@sentry/core-cjs 239.91kB 160 bytes ⬇️
@sentry/profiling-node-cjs 25.5kB 0 bytes
@sentry/profiling-node-esm 25.52kB 0 bytes
@sentry/react-cjs 45.04kB 0 bytes
@sentry/astro-esm 23.39kB 0 bytes
@sentry/core-esm 236.3kB 156 bytes ⬇️
@sentry/wasm-esm 4.85kB 0 bytes
@sentry/vue-esm 18.85kB 0 bytes
@sentry-internal/integration-shims-cjs 3.65kB 0 bytes
@sentry/svelte-esm 12.72kB 0 bytes
@sentry/vercel-edge-cjs 18.27kB 34 bytes ⬆️
@sentry/react-esm 41.18kB 0 bytes
@sentry-internal/integration-shims-esm 2.99kB 0 bytes
@sentry-internal/feedback-cjs 65.81kB 0 bytes
@sentry/vercel-edge-esm 16.18kB 52 bytes ⬆️
@sentry/opentelemetry-cjs 69.66kB 557 bytes ⬇️
@sentry-internal/tracing-cjs 107.89kB 111 bytes ⬇️
@sentry-internal/feedback-esm 65.5kB 0 bytes
@sentry/opentelemetry-esm 68.65kB 535 bytes ⬇️
@sentry-internal/tracing-esm 107.16kB 105 bytes ⬇️

Copy link
Contributor

github-actions bot commented Apr 2, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 76.17 KB (0%)
@sentry/browser (incl. Tracing, Replay) 67.45 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 71.29 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 61.01 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) 32.11 KB (+0.04% 🔺)
@sentry/browser (incl. browserTracingIntegration) 32.11 KB (+0.04% 🔺)
@sentry/browser (incl. feedbackIntegration) 31.33 KB (0%)
@sentry/browser (incl. feedbackModalIntegration) 31.45 KB (0%)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.45 KB (0%)
@sentry/browser (incl. sendFeedback) 27.42 KB (0%)
@sentry/browser 22.57 KB (0%)
CDN Bundle (incl. Tracing, Replay, Feedback) 71.2 KB (+0.04% 🔺)
CDN Bundle (incl. Tracing, Replay) 65.93 KB (+0.04% 🔺)
CDN Bundle (incl. Tracing) 32.27 KB (+0.07% 🔺)
CDN Bundle 23.8 KB (0%)
CDN Bundle (incl. Tracing, Replay) - uncompressed 205.49 KB (+0.02% 🔺)
CDN Bundle (incl. Tracing) - uncompressed 96.14 KB (+0.05% 🔺)
CDN Bundle - uncompressed 70.24 KB (0%)
@sentry/react (incl. Tracing, Replay) 67.44 KB (+0.03% 🔺)
@sentry/react 22.6 KB (0%)

@mydea mydea force-pushed the fn/span-startChild branch from 57a392d to 4d684a6 Compare April 3, 2024 11:12
mydea added 2 commits April 3, 2024 16:26
Also refactor the span logging behavior into a logging integration, to make this consistent between core & otel-powered spans.
@mydea mydea force-pushed the fn/span-startChild branch from 4d684a6 to 5c780a3 Compare April 3, 2024 14:27
@mydea mydea marked this pull request as ready for review April 3, 2024 14:27
@mydea mydea requested review from AbhiPrasad and Lms24 April 3, 2024 14:27
@mydea mydea merged commit 2981b85 into develop Apr 3, 2024
@mydea mydea deleted the fn/span-startChild branch April 3, 2024 14:54
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
Also refactor the span logging behavior into a logging integration, to
make this consistent between core & otel-powered spans.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants