Skip to content

ref(v8): Remove getGlobalObject utility method #11372

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 2, 2024

One more thing to remove...!

@mydea mydea requested review from Lms24 and AbhiPrasad April 2, 2024 11:34
@mydea mydea self-assigned this Apr 2, 2024
Copy link

codecov bot commented Apr 2, 2024

Bundle Report

Changes will decrease total bundle size by 3.39MB ⬇️

Bundle name Size Change
@sentry/vercel-edge-cjs 18.23kB 0 bytes
@sentry/vercel-edge-esm 16.13kB 0 bytes
@sentry/nextjs-cjs 20.52kB 0 bytes
@sentry/nextjs-esm 20.02kB 0 bytes
@sentry/types-cjs (removed) 35 bytes ⬇️
@sentry/types-esm (removed) 35 bytes ⬇️
@sentry/node-esm (removed) 333.56kB ⬇️
@sentry-internal/replay-esm (removed) 306.46kB ⬇️
@sentry-internal/node-integration-tests-cjs (removed) 1.04kB ⬇️
@sentry/node-cjs (removed) 336.97kB ⬇️
@sentry/opentelemetry-cjs (removed) 68.45kB ⬇️
@sentry/utils-cjs (removed) 178.75kB ⬇️
@sentry/bun-cjs (removed) 13.5kB ⬇️
@sentry-internal/replay-canvas-cjs (removed) 29.51kB ⬇️
@sentry-internal/replay-cjs (removed) 306.35kB ⬇️
@sentry/wasm-cjs (removed) 5.2kB ⬇️
@sentry-internal/feedback-esm (removed) 65.5kB ⬇️
@sentry/bun-esm (removed) 10.05kB ⬇️
@sentry/astro-cjs (removed) 27.13kB ⬇️
@sentry/aws-serverless-cjs (removed) 14.62kB ⬇️
@sentry/react-esm (removed) 41.18kB ⬇️
@sentry/utils-esm (removed) 174.17kB ⬇️
@sentry-internal/tracing-cjs (removed) 108.01kB ⬇️
@sentry/svelte-cjs (removed) 13.84kB ⬇️
@sentry-internal/replay-canvas-esm (removed) 29.43kB ⬇️
@sentry/sveltekit-cjs (removed) 69.31kB ⬇️
@sentry/vue-cjs (removed) 20.19kB ⬇️
@sentry/google-cloud-serverless-cjs (removed) 23.0kB ⬇️
@sentry/sveltekit-esm (removed) 61.08kB ⬇️
@sentry/wasm-esm (removed) 4.85kB ⬇️
@sentry/remix-cjs (removed) 53.62kB ⬇️
@sentry/astro-esm (removed) 23.39kB ⬇️
@sentry/remix-esm (removed) 48.23kB ⬇️
@sentry/opentelemetry-esm (removed) 67.4kB ⬇️
@sentry/gatsby-esm (removed) 385 bytes ⬇️
@sentry/gatsby-cjs (removed) 905 bytes ⬇️
@sentry-internal/node-integration-tests-esm (removed) 888 bytes ⬇️
@sentry/vue-esm (removed) 18.85kB ⬇️
@sentry-internal/tracing-esm (removed) 107.26kB ⬇️
@sentry/profiling-node-cjs (removed) 25.5kB ⬇️
@sentry/profiling-node-esm (removed) 25.52kB ⬇️
@sentry/browser-cjs (removed) 107.36kB ⬇️
@sentry/core-cjs (removed) 240.44kB ⬇️
@sentry/google-cloud-serverless-esm (removed) 19.16kB ⬇️
@sentry/core-esm (removed) 236.82kB ⬇️
@sentry-internal/integration-shims-cjs (removed) 3.65kB ⬇️
@sentry-internal/integration-shims-esm (removed) 2.99kB ⬇️
@sentry/browser-esm (removed) 104.53kB ⬇️
@sentry-internal/feedback-cjs (removed) 65.81kB ⬇️

Copy link
Contributor

github-actions bot commented Apr 2, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.46 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) 71.8 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.62 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.37 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) 36.63 KB (+0.02% 🔺)
@sentry/browser (incl. browserTracingIntegration) 36.63 KB (+0.02% 🔺)
@sentry/browser (incl. feedbackIntegration) 31.5 KB (-0.08% 🔽)
@sentry/browser (incl. feedbackModalIntegration) 31.62 KB (-0.04% 🔽)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.63 KB (-0.04% 🔽)
@sentry/browser (incl. sendFeedback) 27.58 KB (-0.04% 🔽)
@sentry/browser 22.74 KB (-0.04% 🔽)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.91 KB (-0.01% 🔽)
CDN Bundle (incl. Tracing, Replay) 69.72 KB (-0.03% 🔽)
CDN Bundle (incl. Tracing) 36.27 KB (-0.03% 🔽)
CDN Bundle 24.01 KB (-0.06% 🔽)
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.77 KB (-0.02% 🔽)
CDN Bundle (incl. Tracing) - uncompressed 109.42 KB (-0.04% 🔽)
CDN Bundle - uncompressed 71.05 KB (-0.05% 🔽)
@sentry/react (incl. Tracing, Replay) 71.78 KB (-0.01% 🔽)
@sentry/react 22.76 KB (-0.11% 🔽)

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP!

@mydea mydea force-pushed the fn/remove-getGlobalObject branch from 7b01ced to 1f956df Compare April 2, 2024 11:59
@mydea mydea merged commit ba9a0f4 into develop Apr 2, 2024
@mydea mydea deleted the fn/remove-getGlobalObject branch April 2, 2024 13:59
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants