Skip to content

fix(web-vitals): Check for undefined navigation entry #11311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

AbhiPrasad
Copy link
Member

resolves #11310

Copy link

codecov bot commented Mar 27, 2024

Bundle Report

Changes will decrease total bundle size by 983.75kB ⬇️

Bundle name Size Change
@sentry-internal/tracing-cjs 108.01kB 35 bytes ⬆️
@sentry-internal/tracing-esm 107.26kB 35 bytes ⬆️
@sentry-internal/replay-canvas-cjs 29.43kB 0 bytes
@sentry/browser-cjs 107.32kB 166 bytes ⬆️
@sentry-internal/replay-canvas-esm 29.34kB 0 bytes
@sentry/node-cjs 336.97kB 0 bytes
@sentry/aws-serverless-cjs 20.29kB 5.67kB ⬆️
@sentry/remix-cjs 53.62kB 0 bytes
@sentry/remix-esm 48.23kB 0 bytes
@sentry/nextjs-esm 20.02kB 0 bytes
@sentry/nextjs-cjs 163.47kB 142.96kB ⬆️
@sentry/browser-esm 104.51kB 166 bytes ⬆️
@sentry/node-esm 333.56kB 0 bytes
@sentry/profiling-node-cjs 25.5kB 0 bytes
@sentry/node-experimental-cjs 157.11kB 0 bytes
@sentry/react-esm 41.18kB 0 bytes
@sentry/profiling-node-esm 25.52kB 0 bytes
@sentry/node-experimental-esm 150.43kB 0 bytes
@sentry/wasm-cjs 5.2kB 5.2kB ⬆️
@sentry/astro-cjs 27.13kB 0 bytes
@sentry-internal/node-integration-tests-cjs 1.04kB 0 bytes
@sentry/svelte-cjs 13.84kB 0 bytes
@sentry-internal/replay-cjs 306.31kB 0 bytes
@sentry/vue-cjs 20.19kB 0 bytes
@sentry/bun-cjs 13.5kB 0 bytes
@sentry/react-cjs 45.04kB 0 bytes
@sentry/astro-esm 23.39kB 0 bytes
@sentry-internal/node-integration-tests-esm 888 bytes 0 bytes
@sentry/wasm-esm 4.85kB 0 bytes
@sentry/vue-esm 18.85kB 0 bytes
@sentry/google-cloud-serverless-cjs 23.0kB 0 bytes
@sentry/gatsby-cjs 905 bytes 0 bytes
@sentry/bun-esm 10.05kB 0 bytes
@sentry/sveltekit-cjs 69.31kB 0 bytes
@sentry/gatsby-esm 385 bytes 0 bytes
@sentry/sveltekit-esm 61.08kB 0 bytes
@sentry/google-cloud-serverless-esm 19.16kB 0 bytes
@sentry-internal/replay-esm 306.42kB 0 bytes
@sentry/svelte-esm 12.72kB 0 bytes
@sentry/types-cjs (removed) 35 bytes ⬇️
@sentry/utils-cjs (removed) 178.75kB ⬇️
@sentry/core-cjs (removed) 240.46kB ⬇️
@sentry/utils-esm (removed) 174.17kB ⬇️
@sentry/core-esm (removed) 236.84kB ⬇️
@sentry/types-esm (removed) 35 bytes ⬇️
@sentry/opentelemetry-cjs (removed) 68.45kB ⬇️
@sentry-internal/integration-shims-cjs (removed) 3.65kB ⬇️
@sentry/vercel-edge-cjs (removed) 18.23kB ⬇️
@sentry/vercel-edge-esm (removed) 16.13kB ⬇️
@sentry-internal/integration-shims-esm (removed) 2.99kB ⬇️
@sentry-internal/feedback-cjs (removed) 65.56kB ⬇️
@sentry-internal/feedback-esm (removed) 65.28kB ⬇️
@sentry/opentelemetry-esm (removed) 67.4kB ⬇️

Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.45 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay) 71.79 KB (-0.01% 🔽)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.61 KB (+0.01% 🔺)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.36 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) 36.62 KB (-0.04% 🔽)
@sentry/browser (incl. browserTracingIntegration) 36.62 KB (-0.04% 🔽)
@sentry/browser (incl. feedbackIntegration) 31.53 KB (+0.47% 🔺)
@sentry/browser (incl. feedbackModalIntegration) 31.63 KB (+0.41% 🔺)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.64 KB (+0.41% 🔺)
@sentry/browser (incl. sendFeedback) 27.59 KB (+0.52% 🔺)
@sentry/browser 22.75 KB (+0.64% 🔺)
CDN Bundle (incl. Tracing, Replay, Feedback) 74.9 KB (+0.01% 🔺)
CDN Bundle (incl. Tracing, Replay) 69.73 KB (+0.01% 🔺)
CDN Bundle (incl. Tracing) 36.27 KB (+0.05% 🔺)
CDN Bundle 24.02 KB (+0.19% 🔺)
CDN Bundle (incl. Tracing, Replay) - uncompressed 218.8 KB (-0.04% 🔽)
CDN Bundle (incl. Tracing) - uncompressed 109.46 KB (+0.01% 🔺)
CDN Bundle - uncompressed 71.08 KB (+0.19% 🔺)
@sentry/react (incl. Tracing, Replay) 71.78 KB (-0.01% 🔽)
@sentry/react 22.78 KB (+0.65% 🔺)

@AbhiPrasad AbhiPrasad merged commit 7e959c5 into develop Mar 27, 2024
@AbhiPrasad AbhiPrasad deleted the abhi-fix-ttfb-getNavigationEntry branch March 27, 2024 15:51
mydea pushed a commit that referenced this pull request Mar 28, 2024
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_addTtfbRequestTimeToMeasurements throws TypeError: undefined is not an object (evaluating 't.responseStart')
2 participants