Skip to content

fix(attachments): Add missing view_hierarchy attachment type #11197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 20, 2024
Merged

fix(attachments): Add missing view_hierarchy attachment type #11197

merged 2 commits into from
Mar 20, 2024

Conversation

krystofwoldrich
Copy link
Member

Adds missing view hierarchy attachment type used in React Native.

@krystofwoldrich krystofwoldrich requested review from timfish, AbhiPrasad, a team and Lms24 and removed request for a team March 19, 2024 09:45
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 19, 2024 •
edited
Loading

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) 80.71 KB (added)
@sentry/browser (incl. Tracing, Replay) 72.06 KB (added)
@sentry/browser (incl. Tracing, Replay with Canvas) 75.86 KB (added)
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 65.62 KB (added)
@sentry/browser (incl. Tracing) 36.66 KB (added)
@sentry/browser (incl. browserTracingIntegration) 36.66 KB (added)
@sentry/browser (incl. feedbackIntegration) 31.33 KB (added)
@sentry/browser (incl. feedbackModalIntegration) 31.45 KB (added)
@sentry/browser (incl. feedbackScreenshotIntegration) 31.46 KB (added)
@sentry/browser (incl. sendFeedback) 27.41 KB (added)
@sentry/browser 22.58 KB (added)
CDN Bundle (incl. Tracing, Replay, Feedback) 75.05 KB (added)
CDN Bundle (incl. Tracing, Replay) 69.9 KB (added)
CDN Bundle (incl. Tracing) 36.25 KB (added)
CDN Bundle 23.95 KB (added)
CDN Bundle (incl. Tracing, Replay) - uncompressed 219.54 KB (added)
CDN Bundle (incl. Tracing) - uncompressed 109.49 KB (added)
CDN Bundle - uncompressed 70.96 KB (added)
@sentry/react (incl. Tracing, Replay) 72.05 KB (added)
@sentry/react 22.61 KB (added)

AbhiPrasad
AbhiPrasad approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@AbhiPrasad AbhiPrasad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs to be part of v7 as well?

@AbhiPrasad
Copy link
Member

Let's also make sure we update https://develop.sentry.dev/sdk/envelopes/#attachment

@krystofwoldrich
Copy link
Member Author

Needs to be part of v7 as well?

Yes, is there v7 branch or how do we backport items?

@krystofwoldrich
Copy link
Member Author

@krystofwoldrich krystofwoldrich mentioned this pull request Mar 20, 2024
Merged
@Lms24
Copy link
Member

Lms24 commented Mar 20, 2024 •
edited
Loading

Yes, is there v7 branch or how do we backport items?

Yes, I recommend cherry-picking the commit and opening a second PR against v7 for it :)

@krystofwoldrich krystofwoldrich merged commit 3ee65ab into develop Mar 20, 2024
@krystofwoldrich krystofwoldrich deleted the kw-add-view-hierarchy-attachment branch March 20, 2024 20:32
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
@krystofwoldrich @cadesalaberry
fix(attachments): Add missing view_hierarchy attachment type (getse…
4fbdb74 
…ntry#11197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timfish timfish timfish approved these changes

@Lms24 Lms24 Lms24 approved these changes

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krystofwoldrich @AbhiPrasad @Lms24 @timfish