feat(v8/replay): Opt-in options for unmask and unblock
#11049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
reviewed
Mar 12, 2024
MIGRATION.md
Outdated
Comment on lines
752
to
753
| unblock: '.sentry-unblock, [data-sentry-unblock]', | ||
| unmask: '.sentry-unmask, [data-sentry-unmask]', |
There was a problem hiding this comment.
Suggested change
| unblock: '.sentry-unblock, [data-sentry-unblock]', | |
| unmask: '.sentry-unmask, [data-sentry-unmask]', | |
| unblock: ['.sentry-unblock, [data-sentry-unblock]'], | |
| unmask: ['.sentry-unmask, [data-sentry-unmask]'], |
mydea
reviewed
Mar 12, 2024
packages/replay/MIGRATION.md
Outdated
Comment on lines
3
to
4
| Sentry Replay is now out of Beta. This means that the usual stability guarantees apply. | ||
|
|
There was a problem hiding this comment.
Suggested change
| Sentry Replay is now out of Beta. This means that the usual stability guarantees apply. |
Let's also remove this while we are here!
mydea
approved these changes
Mar 12, 2024
s1gr1d
force-pushed
the
sig-opt-in-replay-options
branch
from
3a1760e to
359bcc6
Compare
s1gr1d
commented
Mar 12, 2024
There was a problem hiding this comment.
btw: I only changed the test snapshots in the privacyDefault folder. Thought this makes sense, as the default behavior is now "mask everything", even with the data attribute.
In the other tests, I added the unmask array to the options.
s1gr1d
force-pushed
the
sig-opt-in-replay-options
branch
from
359bcc6 to
c695867
Compare
Lms24
approved these changes
Mar 13, 2024
|
Thanks for making this change! This should help a bit with perf as it will have less selectors query when snapshotting DOM changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8887
docs changes: getsentry/sentry-docs#9422