feat(v8): Remove deprecated runWithAsyncContext API #10780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbhiPrasad
requested review from
a team,
mydea and
s1gr1d
and removed request for
a team
s1gr1d
approved these changes
Feb 22, 2024
|
@AbhiPrasad there's no mention of this change in either the in-repo migration guide (https://github.com/getsentry/sentry-javascript/blob/develop/MIGRATION.md) or the one on your docs website (https://docs.sentry.io/platforms/javascript/migration/v7-to-v8). Why was this removed and what can we replace it with? I see from the deleted that the answer to this is |
|
@nwalters512 yes you're right! this is something we missed. I will fix docs accordingly, sorry for the trouble. |
|
opened a migration doc PR here: #12153, will update docs tomorrow given I have to sign off for today! |
mydea
pushed a commit
that referenced
this pull request
May 22, 2024
Adds #10780 to the migration guide.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #10100