Skip to content

isEmptyObject check is uncareful #940

Closed
@LewisJEllis

Description

@LewisJEllis

It has a for key in obj without a if (obj.hasOwnProperty(key)) here.

Actual impact is relatively small; if there's a polluted global object prototype, we might send empty objects when we'd otherwise discard them, and (main concern) we might include a breadcrumb when breadcrumbCallback told us not to.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions