Coerces error-like objects (with stack properties) into strings

[benvinegar]

Raven.js checks if objects passed to Raven.captureException are errors using our isError helper, which is pretty strict: it basically checks if the object in question "descends" from Error using an instanceof check.

But there are some error-like objects out there (e.g. Ember.js) that have .stack properties but do not pass the instanceof Error check. We should probably handle these too.

See: ember-cli-sentry/ember-cli-sentry#72

[benoror]

Hi @benvinegar, any update regarding this? Or any chance to give a hint and/or point out where the change should be made? Regards!

[benoror]

Maybe passing something like:

|| !!what.stack

Somwhere around here (src/utils.js#L14) or here (plugins/ember.js#L22)

(disclaimer: educated guess)

[benvinegar]

There's no point in making this check looser if Sentry is just going to blow up on the object anyways. (e.g. if it's an array of errors).

I still don't have a reproduction case (per the other thread in ember-cli-sentry).

[kamilogorek]

We already improved those checks quite a bit.