Repository navigation
Tracing for Angular is not well integrated into route navigations #3126
Description
Activity
This sounds like a sensible change. However, what should happen on NavigationError or NavigationCancel?
I'm encountering the same behavior in Vue. Any chance of this topic being addressed or discussed further?
Our route-tracing improved when we adjusted the navEnd observable in the routingInstrumentation to account for NavigationCancel and NavigationError events. (taken from here):
public navEnd$: Observable<Event> = this._router.events.pipe( filter(event => event instanceof NavigationEnd || event instanceof NavigationCancel || event instanceof NavigationError), tap(() => { if (this._routingSpan) { runOutsideAngular(() => { // eslint-disable-next-line @typescript-eslint/no-non-null-assertion this._routingSpan!.finish(); }); this._routingSpan = null; } }) );Maybe that should be integrated into the default Angular routingInstrumentation? Because the routing still ends when the navigation is cancelled. Otherwise the route-span just stays open.
Reacted by Daniel Zeiter, Julien Boulay and Joe CottonReacted by Lukas StrackeI would really like this to be fixed, it makes the Sentry tracing useless for tracking pageloads in Angular apps with routing :/
Reacted by Véronique TrudelHi everyone, I'm curious as to how much from this issue is still causing problems for folks.
- Each transaction (shown in the transaction summary) has the name of the initiating page load and lasts for up to 24 hours and it shows navigation events for different angular pages.
- A pageload event inside a transaction has a duration of up to 24hr
I'm using the Angular(-ivy) SDKs in various test projects and hobby projects of mine and page load transactions do finish for me after a couple of seconds, when the browser idles. This is intended behaviour of our
IdleTransactionclass that is used when starting the page load transaction.Our route-tracing improved when we adjusted the navEnd observable in the routingInstrumentation to account for NavigationCancel and NavigationError events
This makes sense to me. I'll open a PR to add these events to the filter. We should finish the routing span in any case when a navigation finishes, not just in the success case.
If anyone is still experiencing 24h pageload transactions, please provide a minimal reproduction (code or even better a gh repo with the reproducible behaviour) so we can look into it. Since in the meantime I'm unable to reproduce this, I'll close the issue once #8369 is merged
Package + Version
@sentry/angularVersion:
Description
I have a feeling that the sentry tracing integration for single page apps or at least for Angular is conceptually wrong and not usable.
The following problems:
Expected behavior:
In summary a think a new transaction for each angular route navigation should be created.
Less important: pageloads and navigations would not be summed up in the same transaction, so that we have a different statistic if a page was loaded via pageload or route navigation.
We integrated tracing via the provided default routingInstrumentation.