Skip to content

node-integration-tests: port trace semantics suites to span streaming #24140

Description

@andreiborza

Follow the porting recipe in the parent issue.

Sampling, DSC, envelope headers and span linking. These suites assert on envelope headers and trace propagation rather than on instrumentation output, so they are the ones most likely to expose a real product bug rather than a test rewrite.

Suites

  • Envelope headers and DSC: tracing/envelope-header/* (7 dirs), tracing/dsc-txn-name-update, tracing/double-baggage/* (3 dirs), tracing/meta-tags, tracing/meta-tags-twp, tracing/meta-tags-twp-errors
  • Sampling: tracing/sampling-static, tracing/sample-rate-propagation/* (4 dirs), tracing/sample-rand-propagation, tracing/no-parent-span-client-report
  • Trace lifetime: tracing/continueTrace, tracing/startNewTrace, tracing/traceid-recycling, tracing/traceid-recycling-with-spans
  • Span shaping: tracing/linking, tracing/maxSpans, tracing/tracer-start-active-span-error
  • Public API span surface: public-api/startSpan/* (7 dirs), public-api/beforeSendSpan-static, public-api/bindScopeToEmitter, public-api/setMeasurement, public-api/scopes/*

Twins to fold back

tracing/sampling-streamed, tracing/ignoreSpans-streamed/*, public-api/beforeSendSpan-streamed, context-streamed/*, and the 6 public-api/startSpan/*-streamed dirs.

Keep static trace lifecycle coverage

This is the group that owns the guard. Keep tracing/sampling-static and public-api/beforeSendSpan-static on the static pin. Everything else moves.

Activity

  1. linear-code commented on Sep 7, 2026

    @linear-code
  2. ihsraham commented on Sep 16, 2026

    @ihsraham
    Contributor

    Is anyone working on the seven tracing/envelope-header/* suites? I'd like to take that group as a separate PR.

    I tried the migration locally on 7267c254. All seven pass with span-header assertions and the existing error-header checks. The sampling-propagation fixture also needs sentry-public_key in its incoming baggage, since streamed envelopes omit tracing context without it. No SDK runtime changes appear necessary.

    Would that scope work for you?

  3. moved this to Waiting for: Product Owner in GitHub Issues with 👀 3on Sep 16, 2026
  4. msonnb commented on Sep 16, 2026

    @msonnb
    Member

    @ihsraham sounds good, feel free to open a PR!

  5. moved this from Waiting for: Product Owner to No status in GitHub Issues with 👀 3on Sep 16, 2026
  6. self-assigned this
    on Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

TaskjavascriptPull requests that update javascript code

Projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions