Skip to content

Future of rewriteFrames? #2254

Description

@7rulnik

SourceMap support was introduced in node@12.11.0. Is rewriteFrames still needed for correct stack-traces?

More details in original PR

Activity

  1. kamilogorek commented on Oct 9, 2019

    @kamilogorek
    Contributor

    Yes, it doesn't change anything for now, as rewriteFrames creates a path that is compatible with default sentry-cli artifacts upload. I'll read what changed in new node versions and see how we can utilize it soon.

  2. 7rulnik commented on Oct 12, 2019

    @7rulnik
    Author

    --source-map-support was introduced in node v12.12. Now it supports stack traces.

    https://github.com/nodejs/node/blob/master/doc/changelogs/CHANGELOG_V12.md#2019-10-11-version-12120-current-bridgear

  3. kamilogorek commented on Jul 2, 2021

    @kamilogorek
    Contributor

    Closing the issue as a part of large repository cleanup, due to it being inactive and/or outdated.
    Please do not hesitate to ping me if it is still relevant, and I will happily reopen and work on it.
    Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions