Skip to content

Doublecheck GRPC Status to Span Status mapping #11195

Open
@lforst

Description

@lforst

Followup to #11169

In the logic where we set a span status based on HTTP_STATUS_CODE or RPC_GRPC_STATUS code, there are two inconsistencies with the spec (https://opentelemetry.io/docs/specs/semconv/rpc/grpc/):

  • We assume the GRPC status codes are stored as string, while the spec says the GRPC status codes are stored as int.
  • We set the status to ERROR for all of the status codes, while the spec says we should set the status to ERROR or UNSET based on whether the span is a client or a server span.

Metadata

Metadata

Assignees

No one assigned

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions