-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Comparing changes
Open a pull request
base repository: getsentry/sentry-javascript
base: 0dcc8cf
head repository: getsentry/sentry-javascript
compare: 99098a1
- 15 commits
- 70 files changed
- 6 contributors
Commits on Mar 25, 2024
-
feat(node): Add scope to ANR events (#11256)
Closes #10668 Rather than inject large unchecked JavaScript strings to run via `Runtime.evaluate`, when the ANR integration is enabled, we add a function to `global.__SENTRY_GET_SCOPES__` which can then be called via the debugger when the event loop is suspended.
Configuration menu - View commit details
-
Copy full SHA for 693f6ca - Browse repository at this point
Copy the full SHA 693f6caView commit details -
test(browser): Test webpack 5 + Terser (#11249)
Tests that an app built with webpack 5 and minified with terser can be built and sends events at runtime
Configuration menu - View commit details
-
Copy full SHA for e057674 - Browse repository at this point
Copy the full SHA e057674View commit details -
fix(node): Skip capturing Hapi Boom error responses. (#11151)
Resolves: #11069 After checking the behaviour, it seems to me that we don't need to capture any Boom responses, as the errors that may cause a `5xx` response are already captured by the core logic. To add an option to control this behaviour, we need to update the usage of `hapiErrorPlugin`, converting it to a function signature, which IMO may not worth doing, as I'm not sure if users in general would need to use it. This also adds `expectError()` to the `node-integration-tests` runner to allow `5xx` responses to be tested.
Configuration menu - View commit details
-
Copy full SHA for 87eed51 - Browse repository at this point
Copy the full SHA 87eed51View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2090a0e - Browse repository at this point
Copy the full SHA 2090a0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for da83bbd - Browse repository at this point
Copy the full SHA da83bbdView commit details -
feat(feedback): Make "required" text for input elements configurable (#…
…11152) (#11153) Fix #11152 This introduces an option `isRequiredLabel`, and I planned to also add `errorMessageText`. However, this PR is branched off from a version that is a couple days old. Right now, @c298lee is currently working on getsentry/sentry#63749, which is causing major changes and the current version on master doesn't work yet. Therefore, I didn't yet implement `errorMessageText`. So consider this PR as a PoC, and either feel free to tag me when the screenshot changes are done – then I'll redo the changes based on the version that supports screenshots – or add the option on your own; however you prefer 🙂 One open question: Until now, there was only the error message: > There was a problem submitting feedback, please wait and try again. Now, depending on the status code, we have three error messages: > - 'Unable to send Feedback. This is because of network issues, or because you are using an ad-blocker.' > - 'Unable to send Feedback. Invalid response from server.' > - 'Unable to send Feedback' Do you have a suggestion how we could make the message configurable, without introducing too many and redundant settings? Maybe we should go back to only one message? I'm not sure if an end-user cares about whether it is a network issue or a server error. --------- Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
Configuration menu - View commit details
-
Copy full SHA for fca5c03 - Browse repository at this point
Copy the full SHA fca5c03View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4291bce - Browse repository at this point
Copy the full SHA 4291bceView commit details -
ref(profiling-node): Remove usage of getCurrentHub (#11275)
Building on top of #11239, this removes usage of `getCurrentHub` in `profiling-node` package by passing in the defined client into the function. This also removes the `createProfilingEventFromTransaction`, which was totally unused.
Configuration menu - View commit details
-
Copy full SHA for b7a50d6 - Browse repository at this point
Copy the full SHA b7a50d6View commit details
Commits on Mar 26, 2024
-
feat(node): Simplify
SentrySpanProcessor
(#11273)Instead of extending `BatchSpanProcessor`, we handle this ourselves now. There may be additional improvements we can do here, but this should be OK for now! I added two tests to cover what we really want to achieve/show here: 1. Ensure that if a span & child span are ended after each other, but in the same tick, they are correctly sent. 2. Ensure that if a child span is ended later, it is skipped. By skipping the batched span processor, we can simplify our flushing a bit and also get rid of some of the delays. For now I kept the exporter as a separate class (it is not exported anyhow, so purely internal), we can eventually look into merging this or not, but this is just a moving-parts-around exercise then. This way, tests continued to work mostly, which is good I'd say.
Configuration menu - View commit details
-
Copy full SHA for 072422f - Browse repository at this point
Copy the full SHA 072422fView commit details -
feat(v8/core): Remove deprecated span.sampled (#11274)
ref #10100 Removes `span.sampled`, and rewrites transaction sampling to avoid mutating transaction.
Configuration menu - View commit details
-
Copy full SHA for 902c93e - Browse repository at this point
Copy the full SHA 902c93eView commit details -
feat(v8): Remove makeMain export (#11278)
ref #10100 Goodbye `makeMain`
Configuration menu - View commit details
-
Copy full SHA for d06af96 - Browse repository at this point
Copy the full SHA d06af96View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9ad23a8 - Browse repository at this point
Copy the full SHA 9ad23a8View commit details -
feat(v8/replay): Remove deprecated replay options
- Remove deprecated privacy options for replay - Add @sentry/replay changes to migration doc - Re-add back Replay migration doc
Configuration menu - View commit details
-
Copy full SHA for e9e2b6e - Browse repository at this point
Copy the full SHA e9e2b6eView commit details -
Configuration menu - View commit details
-
Copy full SHA for b5d0b44 - Browse repository at this point
Copy the full SHA b5d0b44View commit details -
Configuration menu - View commit details
-
Copy full SHA for 99098a1 - Browse repository at this point
Copy the full SHA 99098a1View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff 0dcc8cf...99098a1