Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: getsentry/sentry-javascript
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0dcc8cf
Choose a base ref
...
head repository: getsentry/sentry-javascript
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 99098a1
Choose a head ref
  • 15 commits
  • 70 files changed
  • 6 contributors

Commits on Mar 25, 2024

  1. feat(node): Add scope to ANR events (#11256)

    Closes #10668
    
    Rather than inject large unchecked JavaScript strings to run via
    `Runtime.evaluate`, when the ANR integration is enabled, we add a
    function to `global.__SENTRY_GET_SCOPES__` which can then be called via
    the debugger when the event loop is suspended.
    timfish authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    693f6ca View commit details
    Browse the repository at this point in the history
  2. test(browser): Test webpack 5 + Terser (#11249)

    Tests that an app built with webpack 5 and minified with terser can be
    built and sends events at runtime
    timfish authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    e057674 View commit details
    Browse the repository at this point in the history
  3. fix(node): Skip capturing Hapi Boom error responses. (#11151)

    Resolves: #11069
    
    After checking the behaviour, it seems to me that we don't need to
    capture any Boom responses, as the errors that may cause a `5xx`
    response are already captured by the core logic. To add an option to
    control this behaviour, we need to update the usage of
    `hapiErrorPlugin`, converting it to a function signature, which IMO may
    not worth doing, as I'm not sure if users in general would need to use
    it.
    
    This also adds `expectError()` to the `node-integration-tests` runner to
    allow `5xx` responses to be tested.
    onurtemizkan authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    87eed51 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2090a0e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    da83bbd View commit details
    Browse the repository at this point in the history
  6. feat(feedback): Make "required" text for input elements configurable (#…

    …11152) (#11153)
    
    Fix #11152
    
    This introduces an option `isRequiredLabel`, and I planned to also add
    `errorMessageText`.
    
    However, this PR is branched off from a version that is a couple days
    old. Right now, @c298lee is currently working on getsentry/sentry#63749,
    which is causing major changes and the current version on master doesn't
    work yet. Therefore, I didn't yet implement `errorMessageText`.
    
    So consider this PR as a PoC, and either feel free to tag me when the
    screenshot changes are done – then I'll redo the changes based on the
    version that supports screenshots – or add the option on your own;
    however you prefer 🙂
    
    One open question:
    
    Until now, there was only the error message:
    
    > There was a problem submitting feedback, please wait and try again.
    
    Now, depending on the status code, we have three error messages:
    
    > - 'Unable to send Feedback. This is because of network issues, or
    because you are using an ad-blocker.'
    > - 'Unable to send Feedback. Invalid response from server.'
    > - 'Unable to send Feedback'
    
    Do you have a suggestion how we could make the message configurable,
    without introducing too many and redundant settings? Maybe we should go
    back to only one message? I'm not sure if an end-user cares about
    whether it is a network issue or a server error.
    
    ---------
    
    Co-authored-by: Billy Vong <billyvg@users.noreply.github.com>
    soerface and billyvg authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    fca5c03 View commit details
    Browse the repository at this point in the history
  7. feat(profiling): Use OTEL powered node package (#11239)

    ref #9956
    
    This is another attempt at
    #11033 now that
    #11135 has merged in.
    AbhiPrasad authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    4291bce View commit details
    Browse the repository at this point in the history
  8. ref(profiling-node): Remove usage of getCurrentHub (#11275)

    Building on top of
    #11239, this removes
    usage of `getCurrentHub` in `profiling-node` package by passing in the
    defined client into the function.
    
    This also removes the `createProfilingEventFromTransaction`, which was
    totally unused.
    AbhiPrasad authored Mar 25, 2024
    Configuration menu
    Copy the full SHA
    b7a50d6 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. feat(node): Simplify SentrySpanProcessor (#11273)

    Instead of extending `BatchSpanProcessor`, we handle this ourselves now.
    
    There may be additional improvements we can do here, but this should be
    OK for now!
    
    I added two tests to cover what we really want to achieve/show here:
    
    1. Ensure that if a span & child span are ended after each other, but in
    the same tick, they are correctly sent.
    2. Ensure that if a child span is ended later, it is skipped.
    
    By skipping the batched span processor, we can simplify our flushing a
    bit and also get rid of some of the delays.
    
    For now I kept the exporter as a separate class (it is not exported
    anyhow, so purely internal), we can eventually look into merging this or
    not, but this is just a moving-parts-around exercise then. This way,
    tests continued to work mostly, which is good I'd say.
    mydea authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    072422f View commit details
    Browse the repository at this point in the history
  2. feat(v8/core): Remove deprecated span.sampled (#11274)

    ref #10100
    
    Removes `span.sampled`, and rewrites transaction sampling to avoid
    mutating transaction.
    AbhiPrasad authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    902c93e View commit details
    Browse the repository at this point in the history
  3. feat(v8): Remove makeMain export (#11278)

    ref #10100
    
    Goodbye `makeMain`
    AbhiPrasad authored Mar 26, 2024
    Configuration menu
    Copy the full SHA
    d06af96 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    9ad23a8 View commit details
    Browse the repository at this point in the history
  5. feat(v8/replay): Remove deprecated replay options

    - Remove deprecated privacy options for replay
    - Add @sentry/replay changes to migration doc
    - Re-add back Replay migration doc
    AbhiPrasad committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    e9e2b6e View commit details
    Browse the repository at this point in the history
  6. fix tests

    AbhiPrasad committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    b5d0b44 View commit details
    Browse the repository at this point in the history
  7. fix test

    AbhiPrasad committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    99098a1 View commit details
    Browse the repository at this point in the history
Loading