ref: Use optional chaining wherever possible (#17017)

A future version of eslint flagged & auto-fixed these, extracting this
out for easier review.

Author: mydea

packages/browser/src/integrations/spotlight.ts

@@ -81,8 +81,7 @@ export function isSpotlightInteraction(event: Event): boolean {
   return Boolean(
     event.type === 'transaction' &&
       event.spans &&
-      event.contexts &&
-      event.contexts.trace &&
+      event.contexts?.trace &&
       event.contexts.trace.op === 'ui.action.click' &&
       event.spans.some(({ description }) => description?.includes('#sentry-spotlight')),
   );

packages/browser/src/profiling/utils.ts

@@ -98,7 +98,7 @@ export interface ProfiledEvent extends Event {
 }
 
 function getTraceId(event: Event): string {
-  const traceId: unknown = event.contexts?.trace?.['trace_id'];
+  const traceId: unknown = event.contexts?.trace?.trace_id;
   // Log a warning if the profile has an invalid traceId (should be uuidv4).
   // All profiles and transactions are rejected if this is the case and we want to
   // warn users that this is happening if they enable debug flag
@@ -333,7 +333,7 @@ export function findProfiledTransactionsFromEnvelope(envelope: Envelope): Event[
     for (let j = 1; j < item.length; j++) {
       const event = item[j] as Event;
 
-      if (event?.contexts && event.contexts['profile'] && event.contexts['profile']['profile_id']) {
+      if (event?.contexts?.profile?.profile_id) {
         events.push(item[j] as Event);
       }
     }

packages/core/src/fetch.ts

@@ -204,7 +204,7 @@ function endSpan(span: Span, handlerData: HandlerDataFetch): void {
   if (handlerData.response) {
     setHttpStatus(span, handlerData.response.status);
 
-    const contentLength = handlerData.response?.headers && handlerData.response.headers.get('content-length');
+    const contentLength = handlerData.response?.headers?.get('content-length');
 
     if (contentLength) {
       const contentLengthNum = parseInt(contentLength);

packages/core/src/integrations/dedupe.ts

@@ -176,5 +176,5 @@ function _isSameFingerprint(currentEvent: Event, previousEvent: Event): boolean
 }
 
 function _getExceptionFromEvent(event: Event): Exception | undefined {
-  return event.exception?.values && event.exception.values[0];
+  return event.exception?.values?.[0];
 }

packages/core/src/integrations/rewriteframes.ts

@@ -84,7 +84,7 @@ export const rewriteFramesIntegration = defineIntegration((options: RewriteFrame
   function _processStacktrace(stacktrace?: Stacktrace): Stacktrace {
     return {
       ...stacktrace,
-      frames: stacktrace?.frames && stacktrace.frames.map(f => iteratee(f)),
+      frames: stacktrace?.frames?.map(f => iteratee(f)),
     };
   }
 

packages/core/src/utils/vercelWaitUntil.ts

@@ -18,8 +18,7 @@ export function vercelWaitUntil(task: Promise<unknown>): void {
     // @ts-expect-error This is not typed
     GLOBAL_OBJ[Symbol.for('@vercel/request-context')];
 
-  const ctx =
-    vercelRequestContextGlobal?.get && vercelRequestContextGlobal.get() ? vercelRequestContextGlobal.get() : {};
+  const ctx = vercelRequestContextGlobal?.get?.();
 
   if (ctx?.waitUntil) {
     ctx.waitUntil(task);

packages/feedback/src/modal/integration.tsx

@@ -70,8 +70,8 @@ export const feedbackModalIntegration = ((): FeedbackModalIntegration => {
             screenshotInput={screenshotInput}
             showName={options.showName || options.isNameRequired}
             showEmail={options.showEmail || options.isEmailRequired}
-            defaultName={(userKey && user && user[userKey.name]) || ''}
-            defaultEmail={(userKey && user && user[userKey.email]) || ''}
+            defaultName={(userKey && user?.[userKey.name]) || ''}
+            defaultEmail={(userKey && user?.[userKey.email]) || ''}
             onFormClose={() => {
               renderContent(false);
               options.onFormClose?.();

packages/node-core/src/integrations/spotlight.ts

@@ -20,13 +20,12 @@ const _spotlightIntegration = ((options: Partial<SpotlightConnectionOptions> = {
   return {
     name: INTEGRATION_NAME,
     setup(client) {
-      if (
-        typeof process === 'object' &&
-        process.env &&
-        process.env.NODE_ENV &&
-        process.env.NODE_ENV !== 'development'
-      ) {
-        logger.warn("[Spotlight] It seems you're not in dev mode. Do you really want to have Spotlight enabled?");
+      try {
+        if (process.env.NODE_ENV && process.env.NODE_ENV !== 'development') {
+          logger.warn("[Spotlight] It seems you're not in dev mode. Do you really want to have Spotlight enabled?");
+        }
+      } catch {
+        // ignore
       }
       connectToSpotlight(client, _options);
     },

packages/replay-internal/src/coreHandlers/handleDom.ts

@@ -30,8 +30,7 @@ export const handleDomListener: (replay: ReplayContainer) => (handlerData: Handl
     if (
       isClick &&
       replay.clickDetector &&
-      event &&
-      event.target &&
+      event?.target &&
       !event.altKey &&
       !event.metaKey &&
       !event.ctrlKey &&

packages/replay-internal/src/util/isRrwebError.ts

@@ -4,7 +4,7 @@ import type { Event, EventHint } from '@sentry/core';
  * Returns true if we think the given event is an error originating inside of rrweb.
  */
 export function isRrwebError(event: Event, hint: EventHint): boolean {
-  if (event.type || !event.exception || !event.exception.values || !event.exception.values.length) {
+  if (event.type || !event.exception?.values?.length) {
     return false;
   }