ref: Avoid try-catch with unused parameter (#17015)

Instead, we can just use the parameter-less version of try-catch. In
future versions of eslint, this will be disallowed, so extracting this
out.

Author: mydea

.eslintrc.js

@@ -9,7 +9,7 @@ module.exports = {
     es2017: true,
   },
   parserOptions: {
-    ecmaVersion: 2018,
+    ecmaVersion: 2020,
   },
   extends: ['@sentry-internal/sdk'],
   ignorePatterns: [

dev-packages/browser-integration-tests/scripts/detectFlakyTests.ts

@@ -131,7 +131,7 @@ function getApproximateNumberOfTests(testPath: string): number {
     const content = fs.readFileSync(path.join(process.cwd(), testPath, 'test.ts'), 'utf-8');
     const matches = content.match(/sentryTest\(/g);
     return Math.max(matches ? matches.length : 1, 1);
-  } catch (e) {
+  } catch {
     console.error(`Could not read file ${testPath}`);
     return 1;
   }

dev-packages/browser-integration-tests/suites/feedback/attachTo/test.ts

@@ -17,7 +17,7 @@ sentryTest('should capture feedback with custom button', async ({ getLocalTestUr
 
     try {
       return getEnvelopeType(req) === 'feedback';
-    } catch (err) {
+    } catch {
       return false;
     }
   });

dev-packages/browser-integration-tests/suites/feedback/captureFeedback/test.ts

@@ -17,7 +17,7 @@ sentryTest('should capture feedback', async ({ getLocalTestUrl, page }) => {
 
     try {
       return getEnvelopeType(req) === 'feedback';
-    } catch (err) {
+    } catch {
       return false;
     }
   });

dev-packages/browser-integration-tests/suites/feedback/captureFeedbackAndReplay/hasSampling/test.ts

@@ -25,7 +25,7 @@ sentryTest('should capture feedback', async ({ forceFlushReplay, getLocalTestUrl
 
     try {
       return getEnvelopeType(req) === 'feedback';
-    } catch (err) {
+    } catch {
       return false;
     }
   });

dev-packages/browser-integration-tests/suites/feedback/captureFeedbackCsp/test.ts

@@ -17,7 +17,7 @@ sentryTest('should capture feedback', async ({ getLocalTestUrl, page }) => {
 
     try {
       return getEnvelopeType(req) === 'feedback';
-    } catch (err) {
+    } catch {
       return false;
     }
   });

dev-packages/browser-integration-tests/suites/integrations/moduleMetadata/appliesMetadata/init.js

@@ -14,7 +14,7 @@ Sentry.init({
             moduleMetadataEntries.push(frame.module_metadata);
           });
         });
-      } catch (e) {
+      } catch {
         // noop
       }
     }

dev-packages/browser-integration-tests/suites/integrations/moduleMetadata/appliesMetadataWithRewriteFrames/init.js

@@ -28,7 +28,7 @@ Sentry.init({
             moduleMetadataEntries.push(frame.module_metadata);
           });
         });
-      } catch (e) {
+      } catch {
         // noop
       }
     }

dev-packages/browser-integration-tests/utils/helpers.ts

@@ -23,7 +23,7 @@ export const envelopeParser = (request: Request | null): unknown[] => {
   return envelope.split('\n').map(line => {
     try {
       return JSON.parse(line);
-    } catch (error) {
+    } catch {
       return line;
     }
   });
@@ -172,7 +172,7 @@ export async function runScriptInSandbox(
 ): Promise<void> {
   try {
     await page.addScriptTag({ path: impl.path, content: impl.content });
-  } catch (e) {
+  } catch {
     // no-op
   }
 }

dev-packages/e2e-tests/test-applications/ember-classic/app/controllers/index.ts

@@ -22,7 +22,7 @@ export default class IndexController extends Controller {
   public createCaughtEmberError(): void {
     try {
       throw new Error('Looks like you have a caught EmberError');
-    } catch (e) {
+    } catch {
       // do nothing
     }
   }