Skip to content

ref(core): Use Sentry CLI to create new release #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 8, 2022
Merged

ref(core): Use Sentry CLI to create new release #93

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 0 additions & 51 deletions packages/bundler-plugin-core/src/sentry/api.ts
View file
Open in desktop

This file was deleted.

25 changes: 6 additions & 19 deletions packages/bundler-plugin-core/src/sentry/releasePipeline.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,44 +8,31 @@

import { InternalOptions } from "../options-mapping";
import { BuildContext } from "../types";
import { createRelease } from "./api";
import { addSpanToTransaction } from "./telemetry";

export async function createNewRelease(
options: InternalOptions,
ctx: BuildContext
): Promise<string> {
export async function createNewRelease(options: InternalOptions, ctx: BuildContext): Promise<void> {
const span = addSpanToTransaction(ctx, "function.plugin.create_release");

// TODO: pull these checks out of here and simplify them
if (options.authToken === undefined) {
ctx.logger.warn('Missing "authToken" option. Will not create release.');
return Promise.resolve("nothing to do here");
return;
} else if (options.org === undefined) {
ctx.logger.warn('Missing "org" option. Will not create release.');
return Promise.resolve("nothing to do here");
return;
} else if (options.url === undefined) {
ctx.logger.warn('Missing "url" option. Will not create release.');
return Promise.resolve("nothing to do here");
return;
} else if (options.project === undefined) {
ctx.logger.warn('Missing "project" option. Will not create release.');
return Promise.resolve("nothing to do here");
return;
}

await createRelease({
release: options.release,
authToken: options.authToken,
org: options.org,
project: options.project,
sentryUrl: options.url,
sentryHub: ctx.hub,
customHeader: options.customHeader,
});
await ctx.cli.releases.new(options.release);

ctx.logger.info("Successfully created release.");

span?.finish();
return Promise.resolve("nothing to do here");
}

export async function uploadSourceMaps(options: InternalOptions, ctx: BuildContext): Promise<void> {
Expand Down