Skip to content

Conversation

@Lms24
Copy link
Member

@Lms24 Lms24 commented Nov 3, 2022

This PR brings back Sentry CLI as a dependency and it adjusts a few necessary things to be compatible with the CLI along the way:

  • Add CLI dependency
  • Add getCLI() function which creates a CLI or a stub if in dryRun mode
  • Adjust logger (+ introduce a debug level)
    • dryrun mode of CLI needs it
    • added variable args parameter to fully utilize console.log capabilities
  • Bring back the configFile option as it is relevant again because of Sentry CLI

ref #85

@Lms24 Lms24 requested a review from lforst November 3, 2022 16:53
@Lms24 Lms24 mentioned this pull request Nov 3, 2022
4 tasks
"lint": "eslint ./src ./test"
},
"dependencies": {
"@sentry/cli": "^1.74.6",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we'll still have to go with v1 as long as we don't drop Node 8 and 10 support

Copy link

@lforst lforst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@Lms24 Lms24 enabled auto-merge (squash) November 4, 2022 11:57
@Lms24 Lms24 merged commit 4b7d2e8 into main Nov 4, 2022
@Lms24 Lms24 deleted the lms-cli branch November 4, 2022 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants