Skip to content

fix(core): Stop awaiting build start telemetry to avoid breaking module federation builds #818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 24, 2025
+9 −2
Merged

fix(core): Stop awaiting build start telemetry to avoid breaking module federation builds #818

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e0cd156
fix(core): Stop awaiting build start telemetry to avoid breaking module
andreiborza Oct 24, 2025
ee353fa
Update packages/bundler-plugin-core/src/index.ts
andreiborza Oct 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions packages/bundler-plugin-core/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,15 @@ export function sentryUnpluginFactory({
// Add plugin to emit a telemetry signal when the build starts
plugins.push({
name: "sentry-telemetry-plugin",
async buildStart() {
await sentryBuildPluginManager.telemetry.emitBundlerPluginExecutionSignal();
buildStart() {
// Technically, for very fast builds we might miss the telemetry signal
// but it's okay because telemetry is not critical for us.
// We cannot await the flush here because it would block the build start
// which in turn would break module federation builds, see
// https://github.com/getsentry/sentry-javascript-bundler-plugins/issues/816
void sentryBuildPluginManager.telemetry.emitBundlerPluginExecutionSignal().catch(() => {
// Nothing for the users to do here. If telemetry fails it's acceptable.
});
},
});

Expand Down
Loading