ref(core): Only inject release into entrypoints per default #166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
reviewed
Jan 19, 2023
| @@ -253,15 +219,22 @@ const unplugin = createUnplugin<Options>((options, unpluginMetaContext) => { | |||
| * @param id Always the absolute (fully resolved) path to the module. | |||
| * @returns transformed code + source map | |||
| */ | |||
| transform(code, id) { | |||
| async transform(code, id) { | |||
| logger.debug('Called "transform":', { id }); | |||
|
|
|||
| // The MagicString library allows us to generate sourcemaps for the changes we make to the user code. | |||
| const ms = new MagicString(code); | |||
|
|
|||
| // Appending instead of prepending has less probability of mucking with user's source maps. | |||
There was a problem hiding this comment.
Is this comment still valid/necessary?
|
@Lms24 should be ready for review! |
…-into-entrypoints
|
After upgrading from 0.3.0 to 0.4.0, it seems that release is not injected property. Didn't have any issue on v0.3.0. I am using vite to bundle the assets. X-posted in #178 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #163
Turns out our approach for injecting the release value sucks in case you want to preserve modules while transpiling because we'll create a throwing
require("\0sentry-release-injector")statement since\0sentry-release-injectoris only virtual and you can't "preserve" a virtual file.This PR is fixing this by slightly changing how the
releaseInjectionTargetsoption works. By default we'll inject the release into all entry points now (as opposed to all modules) - without any import magic - just by injecting code. This may have bundle size impact but users can still control how this works by providing a function toreleaseInjectionTargets.